Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: net/third_party/nss/patches/dh1024.patch

Issue 1143303002: NSS: reject DH groups smaller than 1024 bits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: include patch file Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/third_party/nss/patches/applypatches.sh ('k') | net/third_party/nss/ssl/ssl3con.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/third_party/nss/patches/dh1024.patch
diff --git a/net/third_party/nss/patches/dh1024.patch b/net/third_party/nss/patches/dh1024.patch
new file mode 100644
index 0000000000000000000000000000000000000000..99fbcc794fc06d8da31d2d3254a688574575687f
--- /dev/null
+++ b/net/third_party/nss/patches/dh1024.patch
@@ -0,0 +1,14 @@
+diff --git a/ssl/ssl3con.c b/ssl/ssl3con.c
+index 89c98ea..861d434 100644
+--- a/ssl/ssl3con.c
++++ b/ssl/ssl3con.c
+@@ -6946,7 +6946,8 @@ ssl3_HandleServerKeyExchange(sslSocket *ss, SSL3Opaque *b, PRUint32 length)
+ if (rv != SECSuccess) {
+ goto loser; /* malformed. */
+ }
+- if (dh_p.len < 512/8) {
++ if (dh_p.len < 1024/8 ||
++ (dh_p.len == 1024/8 && (dh_p.data[0] & 0x80) == 0)) {
+ errCode = SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY;
+ goto alert_loser;
+ }
« no previous file with comments | « net/third_party/nss/patches/applypatches.sh ('k') | net/third_party/nss/ssl/ssl3con.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698