net/third_party/nss/ssl/ssl3con.c - Issue 1143303002: NSS: reject DH groups smaller than 1024 bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/third_party/nss/ssl/ssl3con.c

Issue 1143303002: NSS: reject DH groups smaller than 1024 bits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: include patch file Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/third_party/nss/ssl/ssl3con.c

diff --git a/net/third_party/nss/ssl/ssl3con.c b/net/third_party/nss/ssl/ssl3con.c

index 89c98eace8786bcf452dd9f1091c6aa5af4eefb2..861d434968c9140bfdf6b760ed5b78d397d3e37d 100644

--- a/net/third_party/nss/ssl/ssl3con.c

+++ b/net/third_party/nss/ssl/ssl3con.c

@@ -6946,7 +6946,8 @@ ssl3_HandleServerKeyExchange(sslSocket *ss, SSL3Opaque *b, PRUint32 length)

if (rv != SECSuccess) {

goto loser; /* malformed. */

}

- if (dh_p.len < 512/8) {

+ if (dh_p.len < 1024/8 ||

+ (dh_p.len == 1024/8 && (dh_p.data[0] & 0x80) == 0)) {

errCode = SSL_ERROR_WEAK_SERVER_EPHEMERAL_DH_KEY;

goto alert_loser;

}

« no previous file with comments | « net/third_party/nss/patches/dh1024.patch ('k') | no next file » | no next file with comments »