Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1143153008: Fall back to older inorder buffer if we have NVPR (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback inc #

Patch Set 3 : tweaks #

Total comments: 1

Patch Set 4 : more feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
joshualitt
5 years, 6 months ago (2015-05-27 17:07:44 UTC) #2
bsalomon
https://codereview.chromium.org/1143153008/diff/1/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (right): https://codereview.chromium.org/1143153008/diff/1/src/gpu/GrInOrderDrawBuffer.cpp#newcode14 src/gpu/GrInOrderDrawBuffer.cpp:14: , fCommands(GrCommandBuilder::Create( seems like a lot of logic in ...
5 years, 6 months ago (2015-05-27 17:16:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143153008/40001
5 years, 6 months ago (2015-05-27 17:24:35 UTC) #6
bsalomon
https://codereview.chromium.org/1143153008/diff/40001/src/gpu/GrInOrderDrawBuffer.cpp File src/gpu/GrInOrderDrawBuffer.cpp (right): https://codereview.chromium.org/1143153008/diff/40001/src/gpu/GrInOrderDrawBuffer.cpp#newcode18 src/gpu/GrInOrderDrawBuffer.cpp:18: , fCommands(GrCommandBuilder::Create(context->getGpu(), We can't get here without a GPU ...
5 years, 6 months ago (2015-05-27 17:26:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143153008/40001
5 years, 6 months ago (2015-05-27 17:30:39 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/b72ec98b2090e5728354dac66eb1886a28e4da6b
5 years, 6 months ago (2015-05-27 17:31:15 UTC) #11
joshualitt
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1160663006/ by joshualitt@google.com. ...
5 years, 6 months ago (2015-05-27 17:39:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143153008/60001
5 years, 6 months ago (2015-05-27 17:45:43 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-05-27 17:56:47 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/24a366a03756d7a8755f940d3160698cf9122cc0

Powered by Google App Engine
This is Rietveld 408576698