Fall back to older inorder buffer if we have NVPR

src/gpu/GrInOrderDrawBuffer.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "GrInOrderDrawBuffer.h"
 
-static const bool kEnableReordering = true;
-
+// We will use the reordering buffer, unless we have NVPR.
+// TODO move NVPR to batch so we can reorder
 GrInOrderDrawBuffer::GrInOrderDrawBuffer(GrContext* context)
     : INHERITED(context)
-    , fCommands(GrCommandBuilder::Create(context->getGpu(), kEnableReordering))
+    , fCommands(GrCommandBuilder::Create(

[bsalomon, 2015/05/27 17:16:06]

seems like a lot of logic in the init list.

static inline bool allow_reodering(const GrCaps& caps) {
    return caps->pathRenderingSupport();
}

GrInOrderDrawBuffer::GrInOrderDrawBuffer(GrContext* context)
    : INHERITED(context)
    ,
fCommands(GrCommandBuilder::Create(allow_reordering(context->getGpu()->caps()))

?

lgtm

+                    context->getGpu(),
+                    !context->getGpu()->caps()->shaderCaps()->pathRenderingSupport()))
     , fPathIndexBuffer(kPathIdxBufferMinReserve * sizeof(char)/4)
     , fPathTransformBuffer(kPathXformBufferMinReserve * sizeof(float)/4)
     , fPipelineBuffer(kPipelineBufferMinReserve)
     , fDrawID(0) {
 }
 
 GrInOrderDrawBuffer::~GrInOrderDrawBuffer() {
     this->reset();
 }
 
@@ skipping 164 matching lines @@
         fPrevState->getPipeline()->isEqual(*state->getPipeline())) {
         this->unallocState(state);
     } else {
         fPrevState.reset(state);
     }
 
     this->recordTraceMarkersIfNecessary(
             fCommands->recordXferBarrierIfNecessary(*fPrevState->getPipeline(), *this->caps()));
     return fPrevState;
 }