|
|
DescriptionDon't add /usr/include32 to include path
This was added a long time ago apparently to support
Ubuntu Lucid: http://codereview.chromium.org/2865032
These days this directory doesn't even exist on ubuntu
or debian.
A recent change to add a check for use_sysroot broke for
target_arch=ia32: https://codereview.chromium.org/1132853010/
Rather than try to fix it this change removes the entire
block.
BUG=489783
Committed: https://crrev.com/eab7867edb4d5a045ddcd24efb313b5a3f47bc83
Cr-Commit-Position: refs/heads/master@{#333196}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 22 (7 generated)
sbc@chromium.org changed reviewers: + jochen@chromium.org, vapier@chromium.org
vapier@chromium.org changed reviewers: + phajdan.jr@chromium.org
i'd be more than happy with this change if bots continue to work. the comment suggested that they really really wanted this path. when i look at the history though, this path was added along with a bunch of hacks to build/install-build-deps.sh. but the latter file had all the lib32/include32 stuff removed from it here: https://codereview.chromium.org/472863002 which means this path no longer works and we can purge it. lgtm
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142793003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
pinging jochen@ for build/OWNERS
ping ... this is the last package we need to fix in CrOS before enabling some QA checks for the whole distro
On 2015/05/27 04:43:08, vapier wrote: > ping ... this is the last package we need to fix in CrOS before enabling some QA > checks for the whole distro pawel, or jochen? Can you take a look at this for build/OWNERS?
LGTM - but I'm not an owner in src/build
ping jochen@...
lgtm
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142793003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by vapier@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142793003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/eab7867edb4d5a045ddcd24efb313b5a3f47bc83 Cr-Commit-Position: refs/heads/master@{#333196} |