Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1142793003: Don't add /usr/include32 to include path (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't add /usr/include32 to include path This was added a long time ago apparently to support Ubuntu Lucid: http://codereview.chromium.org/2865032 These days this directory doesn't even exist on ubuntu or debian. A recent change to add a check for use_sysroot broke for target_arch=ia32: https://codereview.chromium.org/1132853010/ Rather than try to fix it this change removes the entire block. BUG=489783 Committed: https://crrev.com/eab7867edb4d5a045ddcd24efb313b5a3f47bc83 Cr-Commit-Position: refs/heads/master@{#333196}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
Sam Clegg
5 years, 7 months ago (2015-05-19 23:06:04 UTC) #2
vapier
i'd be more than happy with this change if bots continue to work. the comment ...
5 years, 7 months ago (2015-05-20 03:36:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142793003/20001
5 years, 7 months ago (2015-05-20 16:47:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64936)
5 years, 7 months ago (2015-05-20 16:54:20 UTC) #8
Sam Clegg
pinging jochen@ for build/OWNERS
5 years, 7 months ago (2015-05-22 01:38:03 UTC) #9
vapier
ping ... this is the last package we need to fix in CrOS before enabling ...
5 years, 7 months ago (2015-05-27 04:43:08 UTC) #10
Sam Clegg
On 2015/05/27 04:43:08, vapier wrote: > ping ... this is the last package we need ...
5 years, 6 months ago (2015-05-29 18:27:52 UTC) #11
Paweł Hajdan Jr.
LGTM - but I'm not an owner in src/build
5 years, 6 months ago (2015-06-01 10:45:27 UTC) #12
Sam Clegg
ping jochen@...
5 years, 6 months ago (2015-06-03 20:17:05 UTC) #13
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-05 12:09:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142793003/20001
5 years, 6 months ago (2015-06-05 17:33:59 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/32112) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-05 17:49:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142793003/20001
5 years, 6 months ago (2015-06-06 00:45:37 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-06 01:18:46 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 01:19:34 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eab7867edb4d5a045ddcd24efb313b5a3f47bc83
Cr-Commit-Position: refs/heads/master@{#333196}

Powered by Google App Engine
This is Rietveld 408576698