Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 2865032: install-build-deps.sh fixes for Lucid and Chromium OS. (Closed)

Created:
10 years, 5 months ago by Scott Byer
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

install-build-deps.sh fixes for Lucid and Chromium OS. Add in two extra libraries needed for building Chromium-for-Chromium OS on a fresh install Ubuntu Lucid 64-bit. Also, start checking for header differences between the 32-bit and 64-bit packages, adding those headers into the 32-bit cons'ed up package install (on Lucid Lynx, the current libcurl4-gnutls-dev package needs this). Clean up any leftover symbolic links that point nowhere. Also take any declared package conflicts and remove them from the Provides line to allow the cons'ed up package to always install (the package derived from libcurl4-gnutls-dev). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51863

Patch Set 1 #

Total comments: 2

Patch Set 2 : Prepend the 32-bit shadow include directory. #

Patch Set 3 : Fix whitespace at EOLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -18 lines) Patch
M build/common.gypi View 1 1 chunk +10 lines, -0 lines 0 comments Download
M build/install-build-deps.sh View 1 2 4 chunks +51 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
+shell script master http://codereview.chromium.org/2865032/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/2865032/diff/1/2#newcode1015 build/common.gypi:1015: '/usr/include32', I believe there is gyp ...
10 years, 5 months ago (2010-07-01 23:05:33 UTC) #1
Scott Byer
http://codereview.chromium.org/2865032/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/2865032/diff/1/2#newcode1015 build/common.gypi:1015: '/usr/include32', On 2010/07/01 23:05:33, Evan Martin wrote: > I ...
10 years, 5 months ago (2010-07-01 23:31:57 UTC) #2
Markus (顧孟勤)
LGTM
10 years, 5 months ago (2010-07-01 23:52:54 UTC) #3
Evan Martin
10 years, 5 months ago (2010-07-02 18:25:26 UTC) #4
Yeah, Markus's LGTM stands.

Powered by Google App Engine
This is Rietveld 408576698