Remove lib32 code from install-build-deps.sh

Remove lib32 code from install-build-deps.sh

Please see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/_bkkbzJTLWw/SrLN3_XgEJQJ
for more info.

BUG=none
R=mmoss@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290235

[Michael Moss, 2014-08-14 14:59:14]

lgtm

https://codereview.chromium.org/472863002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/472863002/diff/1/build/install-build-deps.sh#...
build/install-build-deps.sh:47: # TODO(phajdan.jr): Remove the lib32 flags when
nothing else refers to them.
I'd almost like to see it fail here, so we can find and remove uses more
quickly. Can it least present a big "OBSOLETE!!!!" warning or something, so
maybe people still using the flag will notice and stop?

[Paweł Hajdan Jr., 2014-08-18 11:49:46]

https://codereview.chromium.org/472863002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/472863002/diff/1/build/install-build-deps.sh#...
build/install-build-deps.sh:47: # TODO(phajdan.jr): Remove the lib32 flags when
nothing else refers to them.
On 2014/08/14 14:59:14, Michael Moss wrote:
> I'd almost like to see it fail here, so we can find and remove uses more
> quickly. Can it least present a big "OBSOLETE!!!!" warning or something, so
> maybe people still using the flag will notice and stop?

That's why I sent a chromium-dev e-mail.

I think a warning even in all caps is easy to miss, and waiting for user input
could break non-interactive workflows.

If this doesn't install the right thing, I'm sure people *will* notice, with or
without the warning.

I got a positive confirmation in that thread that this flag should no longer be
needed.

[Paweł Hajdan Jr., 2014-08-18 12:30:28]

Committed patchset #1 manually as 290235 (presubmit successful).

[Michael Moss, 2014-08-18 15:53:21]

https://codereview.chromium.org/472863002/diff/1/build/install-build-deps.sh
File build/install-build-deps.sh (right):

https://codereview.chromium.org/472863002/diff/1/build/install-build-deps.sh#...
build/install-build-deps.sh:47: # TODO(phajdan.jr): Remove the lib32 flags when
nothing else refers to them.
On 2014/08/18 11:49:45, Paweł Hajdan Jr. wrote:
> On 2014/08/14 14:59:14, Michael Moss wrote:
> > I'd almost like to see it fail here, so we can find and remove uses more
> > quickly. Can it least present a big "OBSOLETE!!!!" warning or something, so
> > maybe people still using the flag will notice and stop?
> 
> That's why I sent a chromium-dev e-mail.
> 
> I think a warning even in all caps is easy to miss, and waiting for user input
> could break non-interactive workflows.
> 
> If this doesn't install the right thing, I'm sure people *will* notice, with
or
> without the warning.
> 
> I got a positive confirmation in that thread that this flag should no longer
be
> needed.

Hence my first sentence where I said I'd like to see it just fail (i.e. take it
out and let it generate a usage error). Why keep accepting it, which implies
it's still doing something?