Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1142453002: [Telemetry] Remove page_test.DidRunTest hook. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove page_test.DidRunTest hook. BUG=435757, 455391 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/604751d0d6fbbc9bc465aa78f41b8a7117d4c182 Cr-Commit-Position: refs/heads/master@{#329862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M tools/perf/benchmarks/dom_perf.py View 3 chunks +27 lines, -16 lines 0 comments Download
M tools/telemetry/telemetry/internal/story_runner_unittest.py View 2 chunks +6 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nednguyen
5 years, 7 months ago (2015-05-13 22:27:29 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-05-14 13:59:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142453002/1
5 years, 7 months ago (2015-05-14 14:56:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_perf_bisect on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-14 16:58:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142453002/1
5 years, 7 months ago (2015-05-14 16:59:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 17:05:45 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 17:06:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/604751d0d6fbbc9bc465aa78f41b8a7117d4c182
Cr-Commit-Position: refs/heads/master@{#329862}

Powered by Google App Engine
This is Rietveld 408576698