Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 1142453002: [Telemetry] Remove page_test.DidRunTest hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test.py
diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py
index a1588a8f54555525f992ed1c8805f52c6e917e02..fa7593a49428e6bc8ba82fa66445263e5029e1d0 100644
--- a/tools/telemetry/telemetry/page/page_test.py
+++ b/tools/telemetry/telemetry/page/page_test.py
@@ -142,13 +142,6 @@ class PageTest(object):
"""Sets the BrowserFinderOptions instance to use."""
self.options = options
- def DidRunTest(self, browser, results): # pylint: disable=W0613
- """Override to do operations after all page set(s) are completed.
-
- This will occur before the browser is torn down.
- """
- self.options = None
-
def WillNavigateToPage(self, page, tab):
"""Override to do operations before the page is navigated, notably Telemetry
will already have performed the following operations on the browser before
« no previous file with comments | « tools/telemetry/telemetry/internal/story_runner_unittest.py ('k') | tools/telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698