tools/telemetry/telemetry/page/shared_page_state.py - Issue 1142453002: [Telemetry] Remove page_test.DidRunTest hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 1142453002: [Telemetry] Remove page_test.DidRunTest hook. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/shared_page_state.py

diff --git a/tools/telemetry/telemetry/page/shared_page_state.py b/tools/telemetry/telemetry/page/shared_page_state.py

index 07180bb68ef331e77f58d6f916a89571fa3aa416..da780d0b59a36318703a70062b238802a7e3bd56 100644

--- a/tools/telemetry/telemetry/page/shared_page_state.py

+++ b/tools/telemetry/telemetry/page/shared_page_state.py

@@ -268,10 +268,6 @@ class SharedPageState(shared_state.SharedState):

raise

def TearDownState(self, results):

- # NOTE: this is a HACK to get story_runner to be generic enough for any

- # user_story while maintaining existing use cases of page tests. Other

- # SharedUserStory should not call DidRunTest this way.

- self._test.DidRunTest(self.browser, results)

self._StopBrowser()

def _StopBrowser(self):

« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | no next file » | no next file with comments »