Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11421194: Hook up the FocusController behind a flag. (Closed)

Created:
8 years ago by Ben Goodger (Google)
Modified:
8 years ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 3

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -108 lines) Patch
M ash/shell.h View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 8 chunks +31 lines, -10 lines 0 comments Download
M ash/wm/app_list_controller.h View 1 2 3 4 5 6 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/app_list_controller.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/ash_focus_rules.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panel_layout_manager.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/panel_layout_manager.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/shelf_layout_manager.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M ash/wm/window_cycle_controller.h View 1 2 3 4 5 6 6 chunks +8 lines, -9 lines 0 comments Download
M ash/wm/window_cycle_controller.cc View 1 2 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M ash/wm/workspace_controller.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_controller.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller_aura.cc View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
A ui/views/corewm/activation_change_shim.h View 1 2 3 4 5 6 1 chunk +48 lines, -0 lines 0 comments Download
A ui/views/corewm/activation_change_shim.cc View 1 2 3 4 5 6 1 chunk +48 lines, -0 lines 0 comments Download
M ui/views/corewm/corewm_switches.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/corewm_switches.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A ui/views/corewm/focus_change_shim.h View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
A ui/views/corewm/focus_change_shim.cc View 1 2 3 4 5 6 1 chunk +45 lines, -0 lines 0 comments Download
M ui/views/corewm/focus_controller.h View 1 2 3 4 5 6 4 chunks +12 lines, -7 lines 0 comments Download
M ui/views/corewm/focus_controller.cc View 1 2 3 4 5 6 5 chunks +34 lines, -14 lines 0 comments Download
M ui/views/corewm/focus_controller_unittest.cc View 1 2 3 4 5 6 11 chunks +40 lines, -36 lines 0 comments Download
M ui/views/corewm/shadow_controller.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/corewm/shadow_controller.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_window_observer.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura_window_observer.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
8 years ago (2012-12-03 04:15:23 UTC) #1
sadrul
8 years ago (2012-12-03 06:32:17 UTC) #2 
LGTM

https://codereview.chromium.org/11421194/diff/7013/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/11421194/diff/7013/ash/shell.cc#newcode225
ash/shell.cc:225: delegate_(delegate),
Initialize activation_client_ here.

https://codereview.chromium.org/11421194/diff/7013/ui/views/corewm/focus_chan...
File ui/views/corewm/focus_change_shim.cc (right):

https://codereview.chromium.org/11421194/diff/7013/ui/views/corewm/focus_chan...
ui/views/corewm/focus_change_shim.cc:27: FocusChangeShim::~FocusChangeShim() {
Does this need to remove itself as a pre-target handler?

https://codereview.chromium.org/11421194/diff/7013/ui/views/corewm/shadow_con...
File ui/views/corewm/shadow_controller.cc (right):

https://codereview.chromium.org/11421194/diff/7013/ui/views/corewm/shadow_con...
ui/views/corewm/shadow_controller.cc:16: #include
"ui/views/corewm/focus_change_event.h"
This doesn't seem necessary

Powered by Google App Engine
This is Rietveld 408576698