Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 11421028: Merge 135131 - input.value="" should clear date/time input elements with partial values (Closed)

Created:
8 years, 1 month ago by tkent
Modified:
8 years, 1 month ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 135131 - input.value="" should clear date/time input elements with partial values https://bugs.webkit.org/show_bug.cgi?id=102645 Reviewed by Kentaro Hara. Source/WebCore: Tests: fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html * html/BaseMultipleFieldsDateAndTimeInputType.cpp: (WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue): If the new value is an empty string and sub-fields has values, we should update the UI value to the empty state. * html/DateTimeFieldsState.h: (WebCore::DateTimeFieldsState::hasAnyValue): Added. It returns true if one or more sub-fields are not empty. LayoutTests: - Add tests for each of date/time input types. - Add them to TextExpectations for platforms without ENABLE_INPUT_MULTIPLE_FIELDS_UI. * fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Added. * fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Added. * fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Added. * fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Added. * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Added. * fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Added. * fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added. * fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Added. * fast/forms/resources/multiple-fields-value-set-empty.js: Added. * fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Added. * fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Added. * fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Added. * fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Added. * platform/chromium-android/TestExpectations: * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/mac/TestExpectations: * platform/qt/TestExpectations: * platform/win/TestExpectations: TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, --8 lines) Patch
A + LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/resources/multiple-fields-value-set-empty.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/chromium-android/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/efl/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/gtk/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/qt/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/DateTimeFieldsState.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tkent
8 years, 1 month ago (2012-11-21 10:51:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698