Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp

Issue 11421028: Merge 135131 - input.value="" should clear date/time input elements with partial values (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/platform/win/TestExpectations ('k') | Source/WebCore/html/DateTimeFieldsState.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 { 291 {
292 if (!m_dateTimeEditElement) 292 if (!m_dateTimeEditElement)
293 return FormControlState(); 293 return FormControlState();
294 294
295 return m_dateTimeEditElement->valueAsDateTimeFieldsState().saveFormControlSt ate(); 295 return m_dateTimeEditElement->valueAsDateTimeFieldsState().saveFormControlSt ate();
296 } 296 }
297 297
298 void BaseMultipleFieldsDateAndTimeInputType::setValue(const String& sanitizedVal ue, bool valueChanged, TextFieldEventBehavior eventBehavior) 298 void BaseMultipleFieldsDateAndTimeInputType::setValue(const String& sanitizedVal ue, bool valueChanged, TextFieldEventBehavior eventBehavior)
299 { 299 {
300 InputType::setValue(sanitizedValue, valueChanged, eventBehavior); 300 InputType::setValue(sanitizedValue, valueChanged, eventBehavior);
301 if (valueChanged) 301 if (valueChanged || (sanitizedValue.isEmpty() && m_dateTimeEditElement && m_ dateTimeEditElement->valueAsDateTimeFieldsState().hasAnyValue()))
302 updateInnerTextValue(); 302 updateInnerTextValue();
303 } 303 }
304 304
305 bool BaseMultipleFieldsDateAndTimeInputType::shouldUseInputMethod() const 305 bool BaseMultipleFieldsDateAndTimeInputType::shouldUseInputMethod() const
306 { 306 {
307 return false; 307 return false;
308 } 308 }
309 309
310 void BaseMultipleFieldsDateAndTimeInputType::stepAttributeChanged() 310 void BaseMultipleFieldsDateAndTimeInputType::stepAttributeChanged()
311 { 311 {
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 { 397 {
398 StepRange stepRange = createStepRange(AnyIsDefaultStep); 398 StepRange stepRange = createStepRange(AnyIsDefaultStep);
399 return date.second() || date.millisecond() 399 return date.second() || date.millisecond()
400 || !stepRange.minimum().remainder(static_cast<int>(msPerMinute)).isZero( ) 400 || !stepRange.minimum().remainder(static_cast<int>(msPerMinute)).isZero( )
401 || !stepRange.step().remainder(static_cast<int>(msPerMinute)).isZero(); 401 || !stepRange.step().remainder(static_cast<int>(msPerMinute)).isZero();
402 } 402 }
403 403
404 } // namespace WebCore 404 } // namespace WebCore
405 405
406 #endif 406 #endif
OLDNEW
« no previous file with comments | « LayoutTests/platform/win/TestExpectations ('k') | Source/WebCore/html/DateTimeFieldsState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698