Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: cc/layer.cc

Issue 11418117: cc: Increment the ref count when assigning the SkImageFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer.cc
diff --git a/cc/layer.cc b/cc/layer.cc
index 5ba8451772c9cb2b6733817c54ebecfd934bfcb4..1ed771085946c200de2324842e5ab81b3d355d4b 100644
--- a/cc/layer.cc
+++ b/cc/layer.cc
@@ -81,8 +81,6 @@ Layer::~Layer()
// Remove the parent reference from all children.
removeAllChildren();
-
- SkSafeUnref(m_filter);
}
void Layer::setUseLCDText(bool useLCDText)
@@ -328,12 +326,12 @@ void Layer::setFilters(const WebKit::WebFilterOperations& filters)
LayerTreeHost::setNeedsFilterContext(true);
}
-void Layer::setFilter(SkImageFilter* filter)
+void Layer::setFilter(const SkRefPtr<SkImageFilter>& filter)
{
- if (m_filter == filter)
+ if (m_filter.get() == filter.get())
return;
DCHECK(m_filters.isEmpty());
- SkRefCnt_SafeAssign(m_filter, filter);
+ m_filter = filter;
setNeedsCommit();
if (filter)
LayerTreeHost::setNeedsFilterContext(true);

Powered by Google App Engine
This is Rietveld 408576698