cc/render_pass_unittest.cc - Issue 11418117: cc: Increment the ref count when assigning the SkImageFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/render_pass_unittest.cc

Issue 11418117: cc: Increment the ref count when assigning the SkImageFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/render_pass_unittest.cc

diff --git a/cc/render_pass_unittest.cc b/cc/render_pass_unittest.cc

index 7a0ec5fad711d6b5156acad17a013856cd982c29..54b6ee004b6a734d29a4dc5010d46cfb2c18b6ed 100644

--- a/cc/render_pass_unittest.cc

+++ b/cc/render_pass_unittest.cc

@@ -48,7 +48,7 @@ TEST(RenderPassTest, copyShouldBeIdenticalExceptIdAndQuads)

filters.append(WebFilterOperation::createGrayscaleFilter(0.2f));

backgroundFilters.append(WebFilterOperation::createInvertFilter(0.2f));

- SkAutoTUnref<SkBlurImageFilter> filter(new SkBlurImageFilter(SK_Scalar1, SK_Scalar1));

Stephen White 2012/11/21 17:23:00 Same here. I think this'll leak.

+ SkRefPtr<SkImageFilter> filter(new SkBlurImageFilter(SK_Scalar1, SK_Scalar1));

scoped_ptr<TestRenderPass> pass = TestRenderPass::Create();

pass->SetAll(id,