Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: cc/layer_impl.h

Issue 11418117: cc: Increment the ref count when assigning the SkImageFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layer_impl.h
diff --git a/cc/layer_impl.h b/cc/layer_impl.h
index 026cdbb837f215097001bb305ffc9b3ef97c412e..23c79a5d8e4083d7aa3b75e46d45b208f9f4a298 100644
--- a/cc/layer_impl.h
+++ b/cc/layer_impl.h
@@ -19,6 +19,8 @@
#include "cc/scoped_ptr_vector.h"
#include "cc/shared_quad_state.h"
#include "third_party/skia/include/core/SkColor.h"
+#include "third_party/skia/include/core/SkImageFilter.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
#include "ui/gfx/rect.h"
#include "ui/gfx/rect_f.h"
#include <public/WebFilterOperations.h>
@@ -115,8 +117,8 @@ public:
void setBackgroundFilters(const WebKit::WebFilterOperations&);
const WebKit::WebFilterOperations& backgroundFilters() const { return m_backgroundFilters; }
- void setFilter(SkImageFilter*);
- SkImageFilter* filter() const { return m_filter; }
+ void setFilter(const SkRefPtr<SkImageFilter>&);
+ SkRefPtr<SkImageFilter> filter() const { return m_filter; }
void setMasksToBounds(bool);
bool masksToBounds() const { return m_masksToBounds; }
@@ -383,7 +385,7 @@ private:
WebKit::WebFilterOperations m_filters;
WebKit::WebFilterOperations m_backgroundFilters;
- SkImageFilter* m_filter;
+ SkRefPtr<SkImageFilter> m_filter;
WebKit::WebTransformationMatrix m_drawTransform;
WebKit::WebTransformationMatrix m_screenSpaceTransform;

Powered by Google App Engine
This is Rietveld 408576698