tools/clang/plugins/tests/virtual_bodies.txt - Issue 1141793003: Update from https://crrev.com/329939

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/virtual_bodies.txt

Issue 1141793003: Update from https://crrev.com/329939 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/tests/virtual_bodies.txt

diff --git a/tools/clang/plugins/tests/virtual_bodies.txt b/tools/clang/plugins/tests/virtual_bodies.txt

index 121d1a96aab5cf53d00f012cac39ff36f143ef7d..c58f98e9d332273df3276f7f7735125f906d121e 100644

--- a/tools/clang/plugins/tests/virtual_bodies.txt

+++ b/tools/clang/plugins/tests/virtual_bodies.txt

@@ -1,5 +1,5 @@

In file included from virtual_bodies.cpp:5:

-./virtual_bodies.h:17:36: warning: [chromium-style] virtual methods with non-empty bodies shouldn't be declared inline.

+./virtual_bodies.h:23:36: warning: [chromium-style] virtual methods with non-empty bodies shouldn't be declared inline.

virtual bool ComplainAboutThis() { return true; }

1 warning generated.