Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/clang/plugins/tests/virtual_bodies.h

Issue 1141793003: Update from https://crrev.com/329939 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/test.sh ('k') | tools/clang/plugins/tests/virtual_bodies.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/virtual_bodies.h
diff --git a/tools/clang/plugins/tests/virtual_bodies.h b/tools/clang/plugins/tests/virtual_bodies.h
index 4ebe695dcbed5cd50e35e0d0022c64e0732b0fcc..fb971c3f1e89dd0d8f7d8cced841dff0b7f4e288 100644
--- a/tools/clang/plugins/tests/virtual_bodies.h
+++ b/tools/clang/plugins/tests/virtual_bodies.h
@@ -5,6 +5,12 @@
#ifndef VIRTUAL_METHODS_H_
#define VIRTUAL_METHODS_H_
+// Note: This is not actual windows.h but the stub file in system/windows.h
+#include <windows.h>
+
+#define CR_BEGIN_MSG_MAP_EX(theClass) virtual int f() { return 4; }
+#define BEGIN_SAFE_MSG_MAP_EX(theClass) virtual int g() { return 4; }
+
// Should warn about virtual method usage.
class VirtualMethodsInHeaders {
public:
@@ -15,6 +21,10 @@ class VirtualMethodsInHeaders {
// But complain about this:
virtual bool ComplainAboutThis() { return true; }
+
+ SYSTEM_INLINE_VIRTUAL
+ CR_BEGIN_MSG_MAP_EX(Sub)
+ BEGIN_SAFE_MSG_MAP_EX(Sub)
};
// Complain on missing 'virtual' keyword in overrides.
« no previous file with comments | « tools/clang/plugins/tests/test.sh ('k') | tools/clang/plugins/tests/virtual_bodies.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698