Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: tools/clang/plugins/tests/virtual_specifiers.cpp

Issue 1141793003: Update from https://crrev.com/329939 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/virtual_bodies.txt ('k') | tools/clang/plugins/tests/virtual_specifiers.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/virtual_specifiers.cpp
diff --git a/tools/clang/plugins/tests/virtual_specifiers.cpp b/tools/clang/plugins/tests/virtual_specifiers.cpp
index 210324809f1ee7d7a41ad3f3108a61f52d6ffd9f..f566ac4f2a6cd205c493f8446803f7f397d29ab2 100644
--- a/tools/clang/plugins/tests/virtual_specifiers.cpp
+++ b/tools/clang/plugins/tests/virtual_specifiers.cpp
@@ -5,6 +5,7 @@
// Tests for chromium style checks for virtual/override/final specifiers on
// virtual methods.
+// Note: This is not actual windows.h but the stub file in system/windows.h
#include <windows.h>
// Purposely use macros to test that the FixIt hints don't try to remove the
@@ -116,3 +117,16 @@ class MyNotTest : public testing::NotTest {
virtual ~MyNotTest();
virtual void SetUp() override;
};
+
+class MacroBase {
+ public:
+ virtual void AddRef() = 0;
+ virtual void Virtual() {}
+};
+
+class Sub : public MacroBase {
+ // Shouldn't warn.
+ END_COM_MAP()
+ SYSTEM_REDUNDANT1;
+ SYSTEM_REDUNDANT2;
+};
« no previous file with comments | « tools/clang/plugins/tests/virtual_bodies.txt ('k') | tools/clang/plugins/tests/virtual_specifiers.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698