tools/clang/plugins/tests/test.sh - Issue 1141793003: Update from https://crrev.com/329939

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/plugins/tests/test.sh

Issue 1141793003: Update from https://crrev.com/329939 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/plugins/tests/test.sh

diff --git a/tools/clang/plugins/tests/test.sh b/tools/clang/plugins/tests/test.sh

index cf262522eb855e291b8f769638bcddce0e9f7114..61bee99f82f229c44a58696e0c9537450ec11a81 100755

--- a/tools/clang/plugins/tests/test.sh

+++ b/tools/clang/plugins/tests/test.sh

@@ -31,8 +31,12 @@ do_testcase() {

flags="$(cat "${3}")"

- if [ "$(uname -s)" = "Darwin" ]; then

- flags="${flags} -isysroot $(xcrun --show-sdk-path) -stdlib=libstdc++"

+ # TODO(thakis): Remove once the tests are standalone, http://crbug.com/486559

+ if [[ "$(uname -s)" == "Darwin" ]]; then

+ flags="${flags} -isysroot $(xcrun --show-sdk-path)"

+ fi

+ if [[ "$(uname -s)" == "Darwin" && "${flags}" != *-target* ]]; then

+ flags="${flags} -stdlib=libstdc++"

flags="${flags} -Xclang -plugin-arg-find-bad-constructs \