Issue 11415046: Change deprecated semantics of function template signatures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415046: Change deprecated semantics of function template signatures. (Closed)

Created:
8 years, 1 month ago by Michael Starzinger

Modified:
8 years ago

Reviewers:
rossberg

CC:
v8-dev, dcarney

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Change deprecated semantics of function template signatures. This changes how FunctionTemplate interprets a Signature that specifies compatible receivers and arguments. An implicit TypeError will be thrown instead of walking up the protoype chain and searching for compatible receivers when the actual receiver mismatches. R=rossberg@chromium.org BUG=v8:2268 TEST=cctest/test-api

Patch Set 1 #

Patch Set 2 : Ported to ARM. #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -165 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1	5 chunks	+12 lines, -27 lines	0 comments	Download
M	src/builtins.cc	View		4 chunks	+19 lines, -34 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		5 chunks	+11 lines, -27 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+1 line, -16 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		5 chunks	+11 lines, -27 lines	0 comments	Download
M	test/cctest/test-api.cc	View		16 chunks	+76 lines, -30 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM. https://codereview.chromium.org/11415046/diff/2001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/11415046/diff/2001/test/cctest/test-api.cc#newcode9943 test/cctest/test-api.cc:9943: "var receiver = o;" Nit: if you want, ...

8 years, 1 month ago (2012-11-20 11:00:08 UTC) #2

Michael Starzinger

8 years ago (2012-11-26 12:57:23 UTC) #3

This is superseeded by https://codereview.chromium.org/11308197/

Expand Messages | Collapse Messages