Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 11308197: Change deprecated semantics of function template signatures. (Closed)

Created:
8 years ago by Michael Starzinger
Modified:
8 years ago
Reviewers:
rossberg
CC:
v8-dev, drcarney
Visibility:
Public.

Description

Change deprecated semantics of function template signatures. This changes how FunctionTemplate interprets a Signature that specifies compatible receivers and arguments. Only the hidden prototype chain will be considered when searching for compatible receivers. This prevents JavaScript from modifying the inheritance relationship set up by the embedder. R=rossberg@chromium.org BUG=v8:2268 TEST=cctest/test-api Committed: http://code.google.com/p/v8/source/detail?r=13131

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -22 lines) Patch
M src/builtins.cc View 1 3 chunks +24 lines, -17 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 10 chunks +45 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
8 years ago (2012-11-26 12:56:58 UTC) #1
rossberg
https://codereview.chromium.org/11308197/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/11308197/diff/1/src/builtins.cc#newcode1272 src/builtins.cc:1272: for (; object != heap->null_value(); object = object->GetPrototype()) { ...
8 years ago (2012-12-03 13:43:19 UTC) #2
Michael Starzinger
Addressed comments. PTAL. https://codereview.chromium.org/11308197/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/11308197/diff/1/src/builtins.cc#newcode1272 src/builtins.cc:1272: for (; object != heap->null_value(); object ...
8 years ago (2012-12-04 12:09:33 UTC) #3
rossberg
8 years ago (2012-12-04 12:51:56 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698