Issue 1141473003: Pass StringPiece by value instead of const ref in SpdyFramer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1141473003: Pass StringPiece by value instead of const ref in SpdyFramer. (Closed)

Created:
5 years, 7 months ago by Bence

Modified:
5 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Pass StringPiece by value instead of const ref in SpdyFramer. This CL lands server change 92358475 by bnc. BUG=488484 Committed: https://crrev.com/acde0a129a2915a7cd1217f942f712744ced0c1d Cr-Commit-Position: refs/heads/master@{#330363}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	net/spdy/spdy_protocol.h	View		4 chunks	+7 lines, -7 lines	0 comments	Download
	M	net/spdy/spdy_protocol.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141473003/1

5 years, 7 months ago (2015-05-18 13:58:45 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-18 15:05:47 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/acde0a129a2915a7cd1217f942f712744ced0c1d
Cr-Commit-Position: refs/heads/master@{#330363}