Pass StringPiece by value instead of const ref in SpdyFramer.

net/spdy/spdy_protocol.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains some protocol structures for use with SPDY 2 and 3
 // The SPDY 2 spec can be found at:
 // http://dev.chromium.org/spdy/spdy-protocol/spdy-protocol-draft2
 // The SPDY 3 spec can be found at:
 // http://dev.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3
 
@@ skipping 596 matching lines @@
 class NET_EXPORT_PRIVATE SpdyFrameWithNameValueBlockIR
     : public NON_EXPORTED_BASE(SpdyFrameWithFinIR) {
  public:
   const SpdyNameValueBlock& name_value_block() const {
     return name_value_block_;
   }
   void set_name_value_block(const SpdyNameValueBlock& name_value_block) {
     // Deep copy.
     name_value_block_ = name_value_block;
   }
-  void SetHeader(const base::StringPiece& name,
-                 const base::StringPiece& value) {
+  void SetHeader(base::StringPiece name, base::StringPiece value) {
     name_value_block_[name.as_string()] = value.as_string();
   }
   SpdyNameValueBlock* mutable_name_value_block() {
     return &name_value_block_;
   }
 
  protected:
   explicit SpdyFrameWithNameValueBlockIR(SpdyStreamId stream_id);
   ~SpdyFrameWithNameValueBlockIR() override;
 
  private:
   SpdyNameValueBlock name_value_block_;
 
   DISALLOW_COPY_AND_ASSIGN(SpdyFrameWithNameValueBlockIR);
 };
 
 class NET_EXPORT_PRIVATE SpdyDataIR
     : public NON_EXPORTED_BASE(SpdyFrameWithFinIR) {
  public:
   // Performs deep copy on data.
-  SpdyDataIR(SpdyStreamId stream_id, const base::StringPiece& data);
+  SpdyDataIR(SpdyStreamId stream_id, base::StringPiece data);
 
   // Use in conjunction with SetDataShallow() for shallow-copy on data.
   explicit SpdyDataIR(SpdyStreamId stream_id);
 
   ~SpdyDataIR() override;
 
   base::StringPiece data() const { return data_; }
 
   bool padded() const { return padded_; }
 
   int padding_payload_len() const { return padding_payload_len_; }
 
   void set_padding_len(int padding_len) {
     DCHECK_GT(padding_len, 0);
     DCHECK_LE(padding_len, kPaddingSizePerFrame);
     padded_ = true;
     // The pad field takes one octet on the wire.
     padding_payload_len_ = padding_len - 1;
   }
 
   // Deep-copy of data (keep private copy).
-  void SetDataDeep(const base::StringPiece& data) {
+  void SetDataDeep(base::StringPiece data) {
     data_store_.reset(new std::string(data.data(), data.length()));
     data_ = *(data_store_.get());
   }
 
   // Shallow-copy of data (do not keep private copy).
-  void SetDataShallow(const base::StringPiece& data) {
+  void SetDataShallow(base::StringPiece data) {
     data_store_.reset();
     data_ = data;
   }
 
   void Visit(SpdyFrameVisitor* visitor) const override;
 
  private:
   // Used to store data that this SpdyDataIR should own.
   scoped_ptr<std::string> data_store_;
   base::StringPiece data_;
@@ skipping 129 matching lines @@
 
  private:
   SpdyPingId id_;
   bool is_ack_;
 
   DISALLOW_COPY_AND_ASSIGN(SpdyPingIR);
 };
 
 class NET_EXPORT_PRIVATE SpdyGoAwayIR : public SpdyFrameIR {
  public:
-  SpdyGoAwayIR(SpdyStreamId last_good_stream_id, SpdyGoAwayStatus status,
-               const base::StringPiece& description);
+  SpdyGoAwayIR(SpdyStreamId last_good_stream_id,
+               SpdyGoAwayStatus status,
+               base::StringPiece description);
   ~SpdyGoAwayIR() override;
   SpdyStreamId last_good_stream_id() const { return last_good_stream_id_; }
   void set_last_good_stream_id(SpdyStreamId last_good_stream_id) {
     DCHECK_LE(0u, last_good_stream_id);
     DCHECK_EQ(0u, last_good_stream_id & ~kStreamIdMask);
     last_good_stream_id_ = last_good_stream_id;
   }
   SpdyGoAwayStatus status() const { return status_; }
   void set_status(SpdyGoAwayStatus status) {
     // TODO(hkhalil): Check valid ranges of status?
@@ skipping 262 matching lines @@
   SpdyFrameVisitor() {}
   virtual ~SpdyFrameVisitor() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SpdyFrameVisitor);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_PROTOCOL_H_