Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: net/spdy/spdy_protocol.cc

Issue 1141473003: Pass StringPiece by value instead of const ref in SpdyFramer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_protocol.cc
diff --git a/net/spdy/spdy_protocol.cc b/net/spdy/spdy_protocol.cc
index 9f311d6b63e500f5c3cc9b2dd9665f5c6ce4c2c6..58a6b2d64d17ac2176bb1f499475c07576837c01 100644
--- a/net/spdy/spdy_protocol.cc
+++ b/net/spdy/spdy_protocol.cc
@@ -11,10 +11,8 @@ SpdyFrameWithNameValueBlockIR::SpdyFrameWithNameValueBlockIR(
SpdyFrameWithNameValueBlockIR::~SpdyFrameWithNameValueBlockIR() {}
-SpdyDataIR::SpdyDataIR(SpdyStreamId stream_id, const base::StringPiece& data)
- : SpdyFrameWithFinIR(stream_id),
- padded_(false),
- padding_payload_len_(0) {
+SpdyDataIR::SpdyDataIR(SpdyStreamId stream_id, base::StringPiece data)
+ : SpdyFrameWithFinIR(stream_id), padded_(false), padding_payload_len_(0) {
SetDataDeep(data);
}
@@ -807,7 +805,7 @@ void SpdyPingIR::Visit(SpdyFrameVisitor* visitor) const {
SpdyGoAwayIR::SpdyGoAwayIR(SpdyStreamId last_good_stream_id,
SpdyGoAwayStatus status,
- const base::StringPiece& description)
+ base::StringPiece description)
: description_(description) {
set_last_good_stream_id(last_good_stream_id);
set_status(status);
« no previous file with comments | « net/spdy/spdy_protocol.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698