Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 11414299: Add content/browser/loader/ for resource loading related classes. (Closed)

Created:
8 years ago by darin (slow to review)
Modified:
8 years ago
Reviewers:
jam
CC:
chromium-reviews, jam, dcheng, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, James Simonsen
Visibility:
Public.

Description

Add content/browser/loader/ for resource loading related classes. This infrastructure is shared by both renderer and worker processes, so having it live in renderer_host/ was not quite right. This change also nicely reduces the number of files in renderer_host/. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171194

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -9324 lines) Patch
M content/browser/android/download_controller_android_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_context.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_resource_handler.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/save_file_manager.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_file_resource_handler.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/async_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/async_resource_handler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/loader/buffered_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/buffered_resource_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/cross_site_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/cross_site_resource_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/loader/doomed_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/doomed_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/layered_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/layered_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/redirect_to_file_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/redirect_to_file_resource_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/loader/resource_buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/loader/resource_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/resource_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/resource_dispatcher_host_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/loader/resource_dispatcher_host_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/browser/loader/resource_dispatcher_host_impl.cc View 2 chunks +10 lines, -10 lines 0 comments Download
A + content/browser/loader/resource_dispatcher_host_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
A + content/browser/loader/resource_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/loader/resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/resource_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/resource_loader.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + content/browser/loader/resource_loader_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/loader/resource_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/loader/resource_message_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/loader/resource_request_info_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/loader/resource_request_info_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/sync_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/sync_resource_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + content/browser/loader/throttling_resource_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/throttling_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/transfer_navigation_resource_throttle.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/loader/transfer_navigation_resource_throttle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/loader/x509_user_cert_resource_handler.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/loader/x509_user_cert_resource_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/browser/renderer_host/async_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -91 lines 0 comments Download
D content/browser/renderer_host/async_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -345 lines 0 comments Download
D content/browser/renderer_host/buffered_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -116 lines 0 comments Download
D content/browser/renderer_host/buffered_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -462 lines 0 comments Download
D content/browser/renderer_host/cross_site_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -75 lines 0 comments Download
D content/browser/renderer_host/cross_site_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -219 lines 0 comments Download
D content/browser/renderer_host/doomed_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -60 lines 0 comments Download
D content/browser/renderer_host/doomed_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -77 lines 0 comments Download
D content/browser/renderer_host/layered_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -47 lines 0 comments Download
D content/browser/renderer_host/layered_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -83 lines 0 comments Download
D content/browser/renderer_host/redirect_to_file_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -107 lines 0 comments Download
D content/browser/renderer_host/redirect_to_file_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -268 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 3 4 5 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 3 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D content/browser/renderer_host/resource_buffer.h View 1 2 3 4 5 1 chunk +0 lines, -128 lines 0 comments Download
D content/browser/renderer_host/resource_buffer.cc View 1 2 3 4 5 1 chunk +0 lines, -181 lines 0 comments Download
D content/browser/renderer_host/resource_buffer_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -137 lines 0 comments Download
D content/browser/renderer_host/resource_dispatcher_host_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -405 lines 0 comments Download
D content/browser/renderer_host/resource_dispatcher_host_impl.h View 1 2 3 4 5 1 chunk +0 lines, -421 lines 0 comments Download
D content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -1729 lines 0 comments Download
D content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -1958 lines 0 comments Download
D content/browser/renderer_host/resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -116 lines 0 comments Download
D content/browser/renderer_host/resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -13 lines 0 comments Download
D content/browser/renderer_host/resource_loader.h View 1 2 3 4 5 1 chunk +0 lines, -124 lines 0 comments Download
D content/browser/renderer_host/resource_loader.cc View 1 2 3 4 5 1 chunk +0 lines, -582 lines 0 comments Download
D content/browser/renderer_host/resource_loader_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/renderer_host/resource_message_filter.h View 1 2 3 4 5 1 chunk +0 lines, -99 lines 0 comments Download
D content/browser/renderer_host/resource_message_filter.cc View 1 2 3 4 5 1 chunk +0 lines, -55 lines 0 comments Download
D content/browser/renderer_host/resource_request_info_impl.h View 1 2 3 4 5 1 chunk +0 lines, -162 lines 0 comments Download
D content/browser/renderer_host/resource_request_info_impl.cc View 1 2 3 4 5 1 chunk +0 lines, -220 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D content/browser/renderer_host/sync_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -74 lines 0 comments Download
D content/browser/renderer_host/sync_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -130 lines 0 comments Download
D content/browser/renderer_host/throttling_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -72 lines 0 comments Download
D content/browser/renderer_host/throttling_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -184 lines 0 comments Download
D content/browser/renderer_host/transfer_navigation_resource_throttle.h View 1 2 3 4 5 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/renderer_host/transfer_navigation_resource_throttle.cc View 1 2 3 4 5 1 chunk +0 lines, -88 lines 0 comments Download
D content/browser/renderer_host/x509_user_cert_resource_handler.h View 1 2 3 4 5 1 chunk +0 lines, -95 lines 0 comments Download
D content/browser/renderer_host/x509_user_cert_resource_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -140 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_cert_error_handler.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/interstitial_page_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 8 chunks +33 lines, -33 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 4 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/test_file_error_injector.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
8 years ago (2012-12-03 21:36:59 UTC) #1
jam
lgtm https://codereview.chromium.org/11414299/diff/3009/content/browser/renderer_host/socket_stream_dispatcher_host.h File content/browser/renderer_host/socket_stream_dispatcher_host.h (right): https://codereview.chromium.org/11414299/diff/3009/content/browser/renderer_host/socket_stream_dispatcher_host.h#newcode1 content/browser/renderer_host/socket_stream_dispatcher_host.h:1: // Copyright (c) 2012 The Chromium Authors. All ...
8 years ago (2012-12-03 22:09:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/11414299/2028
8 years ago (2012-12-04 00:35:09 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-04 00:35:34 UTC) #4
Failed to apply patch for content/browser/loader/async_resource_handler.cc:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  A         content/browser/loader
  Created missing directory content/browser/loader.
  patching file content/browser/loader/async_resource_handler.cc
  Hunk #1 FAILED at 2.
  Hunk #2 FAILED at 16.
  2 out of 2 hunks FAILED -- saving rejects to file
content/browser/loader/async_resource_handler.cc.rej

Patch:   N   content/browser/loader/async_resource_handler.cc
Index: content/browser/loader/async_resource_handler.cc
===================================================================
--- content/browser/loader/async_resource_handler.cc	(working copy)
+++ content/browser/loader/async_resource_handler.cc	(working copy)
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "content/browser/renderer_host/async_resource_handler.h"
+#include "content/browser/loader/async_resource_handler.h"
 
 #include <algorithm>
 #include <vector>
@@ -16,10 +16,10 @@
 #include "base/string_number_conversions.h"
 #include "content/browser/debugger/devtools_netlog_observer.h"
 #include "content/browser/host_zoom_map_impl.h"
-#include "content/browser/renderer_host/resource_buffer.h"
-#include "content/browser/renderer_host/resource_dispatcher_host_impl.h"
-#include "content/browser/renderer_host/resource_message_filter.h"
-#include "content/browser/renderer_host/resource_request_info_impl.h"
+#include "content/browser/loader/resource_buffer.h"
+#include "content/browser/loader/resource_dispatcher_host_impl.h"
+#include "content/browser/loader/resource_message_filter.h"
+#include "content/browser/loader/resource_request_info_impl.h"
 #include "content/browser/resource_context_impl.h"
 #include "content/common/resource_messages.h"
 #include "content/common/view_messages.h"

Powered by Google App Engine
This is Rietveld 408576698