Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 11414148: Hopefully last types fixes. (Closed)

Created:
8 years, 1 month ago by M-A Ruel
Modified:
8 years, 1 month ago
Reviewers:
Peter Mayo, csharp
CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one), cmp+cc_chromium.org
Visibility:
Public.

Description

Hopefully last types fixes. started can sometimes be downgraded to a int and occasionally a None. skipped can occasionally be None instead of False. This should be fixed eventually in the code but leave it there so it can be deserialized. R=csharp@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169370

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M verification/try_job_on_rietveld.py View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
8 years, 1 month ago (2012-11-23 20:43:21 UTC) #1
Peter Mayo
https://codereview.chromium.org/11414148/diff/1/verification/try_job_on_rietveld.py File verification/try_job_on_rietveld.py (right): https://codereview.chromium.org/11414148/diff/1/verification/try_job_on_rietveld.py#newcode59 verification/try_job_on_rietveld.py:59: started = (float, int, None) None (the default) goes ...
8 years, 1 month ago (2012-11-23 20:53:42 UTC) #2
M-A Ruel
https://codereview.chromium.org/11414148/diff/1/verification/try_job_on_rietveld.py File verification/try_job_on_rietveld.py (right): https://codereview.chromium.org/11414148/diff/1/verification/try_job_on_rietveld.py#newcode59 verification/try_job_on_rietveld.py:59: started = (float, int, None) On 2012/11/23 20:53:42, Peter ...
8 years, 1 month ago (2012-11-23 20:55:33 UTC) #3
csharp
lgtm
8 years, 1 month ago (2012-11-23 21:39:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/11414148/1
8 years, 1 month ago (2012-11-23 21:39:47 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-23 21:40:03 UTC) #6
Message was sent while issue was closed.
Change committed as 169370

Powered by Google App Engine
This is Rietveld 408576698