verification/try_job_on_rietveld.py - Issue 11414148: Hopefully last types fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: verification/try_job_on_rietveld.py

Issue 11414148: Hopefully last types fixes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: verification/try_job_on_rietveld.py

diff --git a/verification/try_job_on_rietveld.py b/verification/try_job_on_rietveld.py

index 84c29c35981a7bf5a1403231fe9867e1dce824d1..abbc558885447f9b1673c17693f270c1b8b8f08e 100644

--- a/verification/try_job_on_rietveld.py

+++ b/verification/try_job_on_rietveld.py

@@ -56,7 +56,7 @@ class RietveldTryJob(model.PersistentMixIn):

revision = (None, unicode, int)

requested_steps = list

# The timestamp when the build started.

- started = float

+ started = (float, int, None)

Peter Mayo 2012/11/23 20:53:42 None (the default) goes first, No?

M-A Ruel 2012/11/23 20:55:33 I prefer 0. as the default as I want to get rid of

steps_passed = list

steps_failed = list

clobber = bool

@@ -106,7 +106,7 @@ class RietveldTryJobs(base.IVerifierStatus):

# by Rietveld, so we don't know if the diff is 100% good.

irrelevant = list

# When NOTRY=true is specified.

- skipped = bool

+ skipped = (bool, None)

# Mapping from builders to list of tests.

builders_and_tests = dict

# Mapping from triggered builders to their parent. Do not change this

« no previous file with comments | « no previous file | no next file » | no next file with comments »