Hopefully last types fixes.

verification/try_job_on_rietveld.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Sends patches to the Try server and reads back results.
 
 - RietveldTryJobs contains RietveldTryJob, one per try job on a builder.
 - TryRunnerRietveld uses Rietveld to signal and poll job results.
 """
 
@@ skipping 38 matching lines @@
   """Represents a try job for a pending commit that we care about.
 
   This data can be regenerated by parsing all the try job names but it is a bit
   hard on the try server.
   """
   builder = unicode
   build = int
   revision = (None, unicode, int)
   requested_steps = list
   # The timestamp when the build started.
-  started = float
+  started = (float, int, None)

[Peter Mayo, 2012/11/23 20:53:42]

None (the default) goes first, No?

[M-A Ruel, 2012/11/23 20:55:33]

I prefer 0. as the default as I want to get rid of the Nones (and ints too).

   steps_passed = list
   steps_failed = list
   clobber = bool
   completed = bool
   # Number of retries for this configuration. Initial try is 1.
   tries = int
   parent_key = (None, unicode)
   init_time = float
 
   def __init__(self, **kwargs):
@@ skipping 29 matching lines @@
   completed so another was sent with the missing tests.
   Also, a try job is sent as soon as a test failure is detected.
   """
   # An dict of RietveldTryJob objects per key.
   try_jobs = dict
   # The try job keys we ignore because they can't be used to give a good
   # signal: either they are too old (old revision) or they were not triggerd
   # by Rietveld, so we don't know if the diff is 100% good.
   irrelevant = list
   # When NOTRY=true is specified.
-  skipped = bool
+  skipped = (bool, None)
   # Mapping from builders to list of tests.
   builders_and_tests = dict
   # Mapping from triggered builders to their parent.  Do not change this
   # directly.  Instead use self.update_triggered_builders()
   triggered_builders = dict
   # Jobs that have been sent but are not found yet. Likely a builder is fully
   # utilized or the try server hasn't polled Rietveld yet. list of
   # RietveldTryJobPending() instances.
   pendings = list
 
@@ skipping 458 matching lines @@
     return match and match.group(1).lower() == 'true'
 
   def _update_jobs_from_rietveld(self, pending, jobs):
     """Grabs data from Rietveld and pass it to
     RietveldTryJobs.update_jobs_from_rietveld().
     """
     data = self.context.rietveld.get_patchset_properties(
         pending.issue, pending.patchset)
     return jobs.update_jobs_from_rietveld(
         data, self.status, self.context.checkout)