Issue 11413153: Remove legacy GetURL(),SetURL(),GetFaviconBytes(),SetFaviconBytes()

Issue 11413153: Remove legacy GetURL(),SetURL(),GetFaviconBytes(),SetFaviconBytes() (Closed)

Created:
8 years ago by pkotwicz

Modified:
8 years ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove legacy GetURL(),SetURL(),GetFaviconBytes(),SetFaviconBytes() Bug=None Test=TwoClientBookmarksSyncTest.SC_AddFirstBMWithFavicon Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169972

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Changes as requested #

Patch Set 5 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -75 lines)			Patch
M	chrome/browser/sync/glue/bookmark_change_processor.h	View	1 2 3	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/bookmark_change_processor.cc	View	1 2 3	6 chunks	+25 lines, -17 lines	0 comments	Download
M	chrome/browser/sync/glue/bookmark_model_associator.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_bookmark_unittest.cc	View	1 2 3	2 chunks	+6 lines, -3 lines	0 comments	Download
M	sync/internal_api/base_node.cc	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	sync/internal_api/public/base_node.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	sync/internal_api/public/write_node.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl_unittest.cc	View		6 chunks	+12 lines, -6 lines	0 comments	Download
M	sync/internal_api/write_node.cc	View		2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

Nice! I think you need to update profile_sync_service_bookmark_unittest.cc as well though. https://codereview.chromium.org/11413153/diff/4001/chrome/browser/sync/glue/bookmark_change_processor.h File chrome/browser/sync/glue/bookmark_change_processor.h (right): ...

8 years ago (2012-11-26 22:15:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11413153/2003

8 years ago (2012-11-27 22:27:50 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11413153/2003

8 years ago (2012-11-28 15:09:34 UTC) #6

commit-bot: I haz the power

Failed to trigger a try job on linux_aura HTTP Error 400: Bad Request

8 years ago (2012-11-28 15:09:54 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/11413153/12003

8 years ago (2012-11-28 15:16:44 UTC) #8

Message was sent while issue was closed.

Change committed as 169972

Expand Messages | Collapse Messages