Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: sync/internal_api/public/base_node.h

Issue 11413153: Remove legacy GetURL(),SetURL(),GetFaviconBytes(),SetFaviconBytes() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/base_node.cc ('k') | sync/internal_api/public/write_node.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/public/base_node.h
diff --git a/sync/internal_api/public/base_node.h b/sync/internal_api/public/base_node.h
index b97d5f2c4dd3892dd3df41a237ed19f37354977e..b9c363d97bb49dbd3be91a593473cefbe6577693 100644
--- a/sync/internal_api/public/base_node.h
+++ b/sync/internal_api/public/base_node.h
@@ -113,20 +113,6 @@ class BaseNode {
// data. Can only be called if GetModelType() == BOOKMARK.
const sync_pb::BookmarkSpecifics& GetBookmarkSpecifics() const;
- // Legacy, bookmark-specific getter that wraps GetBookmarkSpecifics() above.
- // Returns the URL of a bookmark object.
- // TODO(ncarter): Remove this datatype-specific accessor.
- GURL GetURL() const;
-
- // Legacy, bookmark-specific getter that wraps GetBookmarkSpecifics() above.
- // Fill in a vector with the byte data of this node's favicon. Assumes
- // that the node is a bookmark.
- // Favicons are expected to be PNG images, and though no verification is
- // done on the syncapi client of this, the server may reject favicon updates
- // that are invalid for whatever reason.
- // TODO(ncarter): Remove this datatype-specific accessor.
- void GetFaviconBytes(std::vector<unsigned char>* output) const;
-
// Getter specific to the APPS datatype. Returns protobuf
// data. Can only be called if GetModelType() == APPS.
const sync_pb::AppSpecifics& GetAppSpecifics() const;
« no previous file with comments | « sync/internal_api/base_node.cc ('k') | sync/internal_api/public/write_node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698