Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: sync/internal_api/public/write_node.h

Issue 11413153: Remove legacy GetURL(),SetURL(),GetFaviconBytes(),SetFaviconBytes() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/internal_api/public/base_node.h ('k') | sync/internal_api/sync_manager_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_INTERNAL_API_PUBLIC_WRITE_NODE_H_ 5 #ifndef SYNC_INTERNAL_API_PUBLIC_WRITE_NODE_H_
6 #define SYNC_INTERNAL_API_PUBLIC_WRITE_NODE_H_ 6 #define SYNC_INTERNAL_API_PUBLIC_WRITE_NODE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 105
106 // Set a new parent and position. Position is specified by |predecessor|; if 106 // Set a new parent and position. Position is specified by |predecessor|; if
107 // it is NULL, the node is moved to the first position. |predecessor| must 107 // it is NULL, the node is moved to the first position. |predecessor| must
108 // be a child of |new_parent| or NULL. Returns false on failure.. 108 // be a child of |new_parent| or NULL. Returns false on failure..
109 bool SetPosition(const BaseNode& new_parent, const BaseNode* predecessor); 109 bool SetPosition(const BaseNode& new_parent, const BaseNode* predecessor);
110 110
111 // Set the bookmark specifics (url and favicon). 111 // Set the bookmark specifics (url and favicon).
112 // Should only be called if GetModelType() == BOOKMARK. 112 // Should only be called if GetModelType() == BOOKMARK.
113 void SetBookmarkSpecifics(const sync_pb::BookmarkSpecifics& specifics); 113 void SetBookmarkSpecifics(const sync_pb::BookmarkSpecifics& specifics);
114 114
115 // Legacy, bookmark-specific setters that wrap SetBookmarkSpecifics() above.
116 // Should only be called if GetModelType() == BOOKMARK.
117 // TODO(ncarter): Remove these two datatype-specific accessors.
118 void SetURL(const GURL& url);
119 void SetFaviconBytes(const std::vector<unsigned char>& bytes);
120
121 // Generic set specifics method. Will extract the model type from |specifics|. 115 // Generic set specifics method. Will extract the model type from |specifics|.
122 void SetEntitySpecifics(const sync_pb::EntitySpecifics& specifics); 116 void SetEntitySpecifics(const sync_pb::EntitySpecifics& specifics);
123 117
124 // Resets the EntitySpecifics for this node based on the unencrypted data. 118 // Resets the EntitySpecifics for this node based on the unencrypted data.
125 // Will encrypt if necessary. 119 // Will encrypt if necessary.
126 void ResetFromSpecifics(); 120 void ResetFromSpecifics();
127 121
128 // TODO(sync): Remove the setters below when the corresponding data 122 // TODO(sync): Remove the setters below when the corresponding data
129 // types are ported to the new sync service API. 123 // types are ported to the new sync service API.
130 124
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 192
199 // The sync API transaction that is the parent of this node. 193 // The sync API transaction that is the parent of this node.
200 WriteTransaction* transaction_; 194 WriteTransaction* transaction_;
201 195
202 DISALLOW_COPY_AND_ASSIGN(WriteNode); 196 DISALLOW_COPY_AND_ASSIGN(WriteNode);
203 }; 197 };
204 198
205 } // namespace syncer 199 } // namespace syncer
206 200
207 #endif // SYNC_INTERNAL_API_PUBLIC_WRITE_NODE_H_ 201 #endif // SYNC_INTERNAL_API_PUBLIC_WRITE_NODE_H_
OLDNEW
« no previous file with comments | « sync/internal_api/public/base_node.h ('k') | sync/internal_api/sync_manager_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698