Switched cc::Resource and cc::ScopedResource to Chrome coding style.

Switched cc::Resource and cc::ScopedResource to Chrome coding style.

BUG=144576, 144577
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168152

[jamesr, 2012-11-15 23:40:09]

lgtm

https://codereview.chromium.org/11412022/diff/10001/cc/resource.cc
File cc/resource.cc (right):

https://codereview.chromium.org/11412022/diff/10001/cc/resource.cc#newcode43
cc/resource.cc:43: 
do you need two blank lines before the "}  // namespace cc" line?

[tfarina, 2012-11-15 23:42:13]

https://codereview.chromium.org/11412022/diff/10001/cc/resource.cc
File cc/resource.cc (right):

https://codereview.chromium.org/11412022/diff/10001/cc/resource.cc#newcode43
cc/resource.cc:43: 
On 2012/11/15 23:40:09, jamesr wrote:
> do you need two blank lines before the "}  // namespace cc" line?
No. Please, just one.

[tfarina, 2012-11-15 23:43:42]

I filled the BUG= line with the corresponding bugs.

Please, remember to update BUG line with the bug numbers in future.

Thanks.

[tfarina, 2012-11-15 23:46:11]

https://codereview.chromium.org/11412022/diff/10001/cc/scoped_resource.h
File cc/scoped_resource.h (right):

https://codereview.chromium.org/11412022/diff/10001/cc/scoped_resource.h#newc...
cc/scoped_resource.h:22: static scoped_ptr<ScopedResource>
create(ResourceProvider* resource_provider) {
static void Foo(Bar* bar) {
                ^If it doesn't fit, move to the next line and indent 4 spaces.
...
}

?

https://codereview.chromium.org/11412022/diff/10001/cc/scoped_resource.h#newc...
cc/scoped_resource.h:27: bool Allocate(int pool, const gfx::Size&, GLenum
format, ResourceProvider::TextureUsageHint);
do want to fix this while you are here?

Write one arg per line. and respect the 80-char columns.

[slavi, 2012-11-16 00:04:35]

On 2012/11/15 23:46:11, tfarina wrote:
> https://codereview.chromium.org/11412022/diff/10001/cc/scoped_resource.h
> File cc/scoped_resource.h (right):
> 
>
https://codereview.chromium.org/11412022/diff/10001/cc/scoped_resource.h#newc...
> cc/scoped_resource.h:22: static scoped_ptr<ScopedResource>
> create(ResourceProvider* resource_provider) {
> static void Foo(Bar* bar) {
>                 ^If it doesn't fit, move to the next line and indent 4 spaces.
> ...
> }

Done.

>
https://codereview.chromium.org/11412022/diff/10001/cc/scoped_resource.h#newc...
> cc/scoped_resource.h:27: bool Allocate(int pool, const gfx::Size&, GLenum
> format, ResourceProvider::TextureUsageHint);
> do want to fix this while you are here?
> 
> Write one arg per line. and respect the 80-char columns.

Done.

PTAL.

[commit-bot: I haz the power, 2012-11-16 02:34:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skaslev@chromium.org/11412022/4004

[commit-bot: I haz the power, 2012-11-16 02:55:53]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-16 03:01:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skaslev@chromium.org/11412022/11006

[commit-bot: I haz the power, 2012-11-16 03:30:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skaslev@chromium.org/11412022/6011

[commit-bot: I haz the power, 2012-11-16 07:36:22]

Change committed as 168152