Issue 11411353: Enforce stack allocation of TryCatch blocks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411353: Enforce stack allocation of TryCatch blocks. (Closed)

Created:
8 years ago by Michael Starzinger

Modified:
8 years ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Enforce stack allocation of TryCatch blocks. R=svenpanne@chromium.org BUG=v8:2166, chromium:152389 Committed: http://code.google.com/p/v8/source/detail?r=13130

Patch Set 2 : Addressed comments by Sven Panne. #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	include/v8.h	View	1	3 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with a nit https://codereview.chromium.org/11411353/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/11411353/diff/1/include/v8.h#newcode3654 include/v8.h:3654: // Make it impossible to ...

8 years ago (2012-12-04 11:55:28 UTC) #1

Michael Starzinger

8 years ago (2012-12-04 12:12:40 UTC) #2

Addressed comments. Landing.

https://codereview.chromium.org/11411353/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/11411353/diff/1/include/v8.h#newcode3654
include/v8.h:3654: // Make it impossible to create heap-allocated TryCatch
blocks.
On 2012/12/04 11:55:28, Sven Panne wrote:
> s/impossible/hard/, same for other places like this

Done.

Expand Messages | Collapse Messages

Issue 11411353: Enforce stack allocation of TryCatch blocks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Sven Panne. #

Messages