Enforce stack allocation of TryCatch blocks.

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3541 matching lines @@
   friend class Context;
 };
 
 
 /**
  * An external exception handler.
  */
 class V8EXPORT TryCatch {
  public:
   /**
-   * Creates a new try/catch block and registers it with v8.
+   * Creates a new try/catch block and registers it with v8.  Note that
+   * all TryCatch blocks should be stack allocated because the memory
+   * location itself is compared against JavaScript try/catch blocks.
    */
   TryCatch();
 
   /**
    * Unregisters and deletes this try/catch block.
    */
   ~TryCatch();
 
   /**
    * Returns true if an exception has been caught by this try/catch block.
@@ skipping 69 matching lines @@
   void SetVerbose(bool value);
 
   /**
    * Set whether or not this TryCatch should capture a Message object
    * which holds source information about where the exception
    * occurred.  True by default.
    */
   void SetCaptureMessage(bool value);
 
  private:
+  // Make it impossible to create heap-allocated TryCatch blocks.

[Sven Panne, 2012/12/04 11:55:28]

s/impossible/hard/, same for other places like this

[Michael Starzinger, 2012/12/04 12:12:40]

Done.

+  TryCatch(const TryCatch&);
+  void operator=(const TryCatch&);
+  void* operator new(size_t size);
+  void operator delete(void*, size_t);
+
   v8::internal::Isolate* isolate_;
   void* next_;
   void* exception_;
   void* message_;
   bool is_verbose_ : 1;
   bool can_continue_ : 1;
   bool capture_message_ : 1;
   bool rethrow_ : 1;
 
   friend class v8::internal::Isolate;
@@ skipping 1144 matching lines @@
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_