Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: include/v8.h

Issue 11411353: Enforce stack allocation of TryCatch blocks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Sven Panne. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 01a4cc9dea7f9e29b565597e3b984215a96ed91f..74f489d2ab7870bba38e7bb46dfd10b1bba93401 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -490,8 +490,8 @@ class V8EXPORT HandleScope {
static internal::Object** CreateHandle(internal::HeapObject* value);
private:
- // Make it impossible to create heap-allocated or illegal handle
- // scopes by disallowing certain operations.
+ // Make it hard to create heap-allocated or illegal handle scopes by
+ // disallowing certain operations.
HandleScope(const HandleScope&);
void operator=(const HandleScope&);
void* operator new(size_t size);
@@ -3559,7 +3559,9 @@ class V8EXPORT V8 {
class V8EXPORT TryCatch {
public:
/**
- * Creates a new try/catch block and registers it with v8.
+ * Creates a new try/catch block and registers it with v8. Note that
+ * all TryCatch blocks should be stack allocated because the memory
+ * location itself is compared against JavaScript try/catch blocks.
*/
TryCatch();
@@ -3649,6 +3651,12 @@ class V8EXPORT TryCatch {
void SetCaptureMessage(bool value);
private:
+ // Make it hard to create heap-allocated TryCatch blocks.
+ TryCatch(const TryCatch&);
+ void operator=(const TryCatch&);
+ void* operator new(size_t size);
+ void operator delete(void*, size_t);
+
v8::internal::Isolate* isolate_;
void* next_;
void* exception_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698