Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 11411308: Enable script bubble by default on all but mac. (Closed)

Created:
8 years ago by Aaron Boodman
Modified:
8 years ago
Reviewers:
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Enable script bubble by default on all but mac. This is a combination of https://codereview.chromium.org/11308302/ and https://codereview.chromium.org/11434064/, with some fixes to tests. BUG=153137 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170689

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : bring back ScriptBubbleControllerUnittest #

Patch Set 4 : Everything passes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -168 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 4 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/page_action_controller.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/script_badge_controller_unittest.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/script_bubble_controller.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/script_bubble_controller.cc View 1 2 3 3 chunks +10 lines, -1 line 0 comments Download
D chrome/browser/extensions/script_bubble_controller_unittest.cc View 1 2 7 chunks +2 lines, -19 lines 0 comments Download
M chrome/browser/extensions/tab_helper.cc View 1 2 3 3 chunks +33 lines, -15 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/script_bubble/16.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/script_bubble/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/resources/script_bubble/popup.html View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/resources/script_bubble/popup.js View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/common/extensions/feature_switch.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/11411308/9017
8 years ago (2012-12-02 02:46:33 UTC) #1
commit-bot: I haz the power
8 years ago (2012-12-02 06:04:27 UTC) #2
Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698