Enable script bubble by default on all but mac.

chrome/browser/extensions/script_bubble_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 28 matching lines @@
   }
 
   virtual void SetUp() OVERRIDE {
     ChromeRenderViewHostTestHarness::SetUp();
     CommandLine command_line(CommandLine::NO_PROGRAM);
     Profile* profile =
         Profile::FromBrowserContext(web_contents()->GetBrowserContext());
     extension_service_ = static_cast<TestExtensionSystem*>(
         ExtensionSystem::Get(profile))->CreateExtensionService(
             &command_line, FilePath(), false);
-    extension_service_->component_loader()->AddScriptBubble();
     extension_service_->Init();
 
     TabHelper::CreateForWebContents(web_contents());
 
     script_bubble_controller_ =
         TabHelper::FromWebContents(web_contents())->script_bubble_controller();
   }
 
  protected:
   int tab_id() {
@@ skipping 39 matching lines @@
       .SetManifest(DictionaryBuilder()
                    .Set("name", "ex3")
                    .Set("version", "1")
                    .Set("manifest_version", 2))
       .Build();
 
   extension_service_->AddExtension(extension1);
   extension_service_->AddExtension(extension2);
   extension_service_->AddExtension(extension3);
 
-  const Extension* script_bubble =
-      extension_service_->component_loader()->GetScriptBubble();
-  ExtensionAction* script_bubble_action =
-      ExtensionActionManager::Get(profile())->GetPageAction(*script_bubble);
-  ASSERT_TRUE(script_bubble_action);
+  EXPECT_EQ(0u, script_bubble_controller_->extensions_running_scripts().size());
 
-  // By default, the bubble should be invisible.
   NavigateAndCommit(GURL("http://www.google.com"));
-  EXPECT_FALSE(script_bubble_action->GetIsVisible(tab_id()));
-  EXPECT_EQ("", script_bubble_action->GetBadgeText(tab_id()));
-  EXPECT_EQ(0u, script_bubble_controller_->extensions_running_scripts().size());
 
   // Running a script on the tab causes the bubble to be visible.
   TabHelper::ScriptExecutionObserver::ExecutingScriptsMap executing_scripts;
   executing_scripts[extension1->id()].insert("script1");
   script_bubble_controller_->OnScriptsExecuted(
       web_contents(),
       executing_scripts,
       web_contents()->GetController().GetActiveEntry()->GetPageID(),
       web_contents()->GetController().GetActiveEntry()->GetURL());
-  // TODO(finnur): Figure out visibility test.
-  // EXPECT_TRUE(script_bubble_action->GetIsVisible(tab_id()));
   EXPECT_EQ(1u, script_bubble_controller_->extensions_running_scripts().size());
   std::set<std::string> extension_ids;
   extension_ids.insert(extension1->id());
   EXPECT_EQ(1u, script_bubble_controller_->extensions_running_scripts().size());
   EXPECT_TRUE(extension_ids ==
              script_bubble_controller_->extensions_running_scripts());
 
   // Running a script from another extension increments the count.
   executing_scripts.clear();
   executing_scripts[extension2->id()].insert("script2");
   script_bubble_controller_->OnScriptsExecuted(
       web_contents(),
       executing_scripts,
       web_contents()->GetController().GetActiveEntry()->GetPageID(),
       web_contents()->GetController().GetActiveEntry()->GetURL());
-  // EXPECT_TRUE(script_bubble_action->GetIsVisible(tab_id()));
   EXPECT_EQ(2u, script_bubble_controller_->extensions_running_scripts().size());
   extension_ids.insert(extension2->id());
   EXPECT_TRUE(extension_ids ==
              script_bubble_controller_->extensions_running_scripts());
 
   // Running another script from an already-seen extension does not affect
   // count.
   executing_scripts.clear();
   executing_scripts[extension2->id()].insert("script3");
   script_bubble_controller_->OnScriptsExecuted(
       web_contents(),
       executing_scripts,
       web_contents()->GetController().GetActiveEntry()->GetPageID(),
       web_contents()->GetController().GetActiveEntry()->GetURL());
-  // EXPECT_TRUE(script_bubble_action->GetIsVisible(tab_id()));
   EXPECT_EQ(2u, script_bubble_controller_->extensions_running_scripts().size());
 
   // Running tabs.executeScript from an already-seen extension does not affect
   // count.
   executing_scripts.clear();
   executing_scripts[extension1->id()] = std::set<std::string>();
   script_bubble_controller_->OnScriptsExecuted(
       web_contents(), executing_scripts, 0, GURL());
-  // EXPECT_TRUE(script_bubble_action->GetIsVisible(tab_id()));
   EXPECT_EQ(2u, script_bubble_controller_->extensions_running_scripts().size());
 
   // Running tabs.executeScript from a new extension increments the count.
   executing_scripts.clear();
   executing_scripts[extension3->id()] = std::set<std::string>();
   script_bubble_controller_->OnScriptsExecuted(
       web_contents(), executing_scripts, 0, GURL());
-  // EXPECT_TRUE(script_bubble_action->GetIsVisible(tab_id()));
-  extension_ids.insert(extension3->id());
   EXPECT_EQ(3u, script_bubble_controller_->extensions_running_scripts().size());
 
   // Navigating away resets the badge.
   NavigateAndCommit(GURL("http://www.google.com"));
-  EXPECT_FALSE(script_bubble_action->GetIsVisible(tab_id()));
-  EXPECT_EQ("", script_bubble_action->GetBadgeText(tab_id()));
+  EXPECT_EQ(0u, script_bubble_controller_->extensions_running_scripts().size());
 };
 
 }  // namespace
 }  // namespace extensions