Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: chrome/browser/extensions/script_badge_controller_unittest.cc

Issue 11411308: Enable script bubble by default on all but mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Everything passes Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/script_badge_controller_unittest.cc
diff --git a/chrome/browser/extensions/script_badge_controller_unittest.cc b/chrome/browser/extensions/script_badge_controller_unittest.cc
index 5786ccd61ad65de59c9b353ac565d4a3994551e4..c6ec141e2634e0ee1e72d3e74923c4a774f36979 100644
--- a/chrome/browser/extensions/script_badge_controller_unittest.cc
+++ b/chrome/browser/extensions/script_badge_controller_unittest.cc
@@ -203,7 +203,15 @@ TEST_F(ScriptBadgeControllerTest, FragmentNavigation) {
EXPECT_THAT(script_badge_controller_->GetCurrentActions(),
testing::ElementsAre());
+
+ // Should be zero, but ScriptBubbleController notifies updates via
+ // LocationBarController and causes an update here.
+#if defined(OS_MACOSX)
+ // Not enabled on mac yet
EXPECT_EQ(0, location_bar_updated.events);
+#else
+ EXPECT_EQ(1, location_bar_updated.events);
+#endif
}
}
« no previous file with comments | « chrome/browser/extensions/page_action_controller.cc ('k') | chrome/browser/extensions/script_bubble_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698