Record UMA about the response's proxy_server in the DRP bypass logic.

Record UMA about the response's proxy_server in the DRP bypass logic.

This will help us analyze how often the Data Reduction Proxy bypass
logic is applied for proxies that don't match the currently configured
Data Reduction Proxies, but do have the DRP via header in the response.

BUG=487852
Committed: https://crrev.com/c29c04b5a355aebe0f4d8f1fac7ea79ebaa8e1eb
Cr-Commit-Position: refs/heads/master@{#329924}

[sclittle, 2015-05-13 23:18:20]

sclittle@chromium.org changed reviewers:
+ asvitkine@chromium.org, jeremyim@chromium.org

[sclittle, 2015-05-13 23:18:20]

jeremyim: components/data_reduction_proxy
asvitkine: histograms.xml

Thanks in advance!

[jeremyim, 2015-05-14 00:02:42]

components/data_reduction_proxy lgtm % nit

https://codereview.chromium.org/1141023002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
(right):

https://codereview.chromium.org/1141023002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc:23:
#include
"components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h"
This (and data_reduction_proxy_params.h) can probably be removed in most of the
DataReductionProxyTestContext::Builder() cleanup locations if the test does not
need to access the params object.

[sclittle, 2015-05-14 01:10:41]

https://codereview.chromium.org/1141023002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
(right):

https://codereview.chromium.org/1141023002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc:23:
#include
"components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h"
On 2015/05/14 00:02:42, jeremyim wrote:
> This (and data_reduction_proxy_params.h) can probably be removed in most of
the
> DataReductionProxyTestContext::Builder() cleanup locations if the test does
not
> need to access the params object.

Done. This one here was still needed, since some of the tests use
test_params()->DefaultOrigin(), but I've removed the unnecessary ones.

[Alexei Svitkine (slow), 2015-05-14 14:54:44]

https://codereview.chromium.org/1141023002/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
(right):

https://codereview.chromium.org/1141023002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:7:
#include "base/metrics/histogram.h"
Include histogram_macros.h instead.

https://codereview.chromium.org/1141023002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:95:
UMA_HISTOGRAM_ENUMERATION("DataReductionProxy.ResponseProxyServerStatus",
Each histogram macro expands to a lot of code. Please make a helper function in
the anon namespace to log this histogram which takes the enum value as a param.

[sclittle, 2015-05-14 17:59:51]

https://codereview.chromium.org/1141023002/diff/20001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
(right):

https://codereview.chromium.org/1141023002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:7:
#include "base/metrics/histogram.h"
On 2015/05/14 14:54:44, Alexei Svitkine wrote:
> Include histogram_macros.h instead.

Done.

https://codereview.chromium.org/1141023002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:95:
UMA_HISTOGRAM_ENUMERATION("DataReductionProxy.ResponseProxyServerStatus",
On 2015/05/14 14:54:44, Alexei Svitkine wrote:
> Each histogram macro expands to a lot of code. Please make a helper function
in
> the anon namespace to log this histogram which takes the enum value as a
param.

Done.

[Alexei Svitkine (slow), 2015-05-14 18:01:19]

lgtm

https://codereview.chromium.org/1141023002/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
(right):

https://codereview.chromium.org/1141023002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc:805:
};
Nit: DISALLOW_COPY_AND_ASSIGN

[sclittle, 2015-05-14 18:05:59]

https://codereview.chromium.org/1141023002/diff/40001/components/data_reducti...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc
(right):

https://codereview.chromium.org/1141023002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc:805:
};
On 2015/05/14 18:01:19, Alexei Svitkine wrote:
> Nit: DISALLOW_COPY_AND_ASSIGN

Done.

[sclittle, 2015-05-14 18:06:19]

The CQ bit was checked by sclittle@chromium.org

[sclittle, 2015-05-14 18:06:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeremyim@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1141023002/#ps60001
(title: "Addressed nit")

[commit-bot: I haz the power, 2015-05-14 18:06:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141023002/60001

[commit-bot: I haz the power, 2015-05-14 18:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 18:12:59]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sclittle, 2015-05-14 18:30:39]

The CQ bit was checked by sclittle@chromium.org

[sclittle, 2015-05-14 18:30:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeremyim@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1141023002/#ps80001
(title: "Rebased on master")

[commit-bot: I haz the power, 2015-05-14 18:31:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141023002/80001

[sclittle, 2015-05-14 18:37:40]

The CQ bit was unchecked by sclittle@chromium.org

[commit-bot: I haz the power, 2015-05-14 18:38:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 18:38:38]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sclittle, 2015-05-14 18:39:48]

The CQ bit was checked by sclittle@chromium.org

[sclittle, 2015-05-14 18:39:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeremyim@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1141023002/#ps100001
(title: "Rebased on master again")

[commit-bot: I haz the power, 2015-05-14 18:40:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141023002/100001

[commit-bot: I haz the power, 2015-05-14 20:41:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-14 20:43:15]

Patchset 6 (id:??) landed as
https://crrev.com/c29c04b5a355aebe0f4d8f1fac7ea79ebaa8e1eb
Cr-Commit-Position: refs/heads/master@{#329924}