components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc - Issue 1141023002: Record UMA about the response's proxy_server in the DRP bypass logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 1141023002: Record UMA about the response's proxy_server in the DRP bypass logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased on master again Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

index 0bcc7801aeb3ea340b85b0339385810d8e5b40fc..b169f30af99e6252ab62df2e31d2d2244d5583cc 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

@@ -174,13 +174,6 @@ TEST(DataReductionProxySettingsStandaloneTest, TestEndToEndSecureProxyCheck) {

scoped_ptr<DataReductionProxyTestContext> drp_test_context =

DataReductionProxyTestContext::Builder()

- .WithParamsFlags(DataReductionProxyParams::kAllowed |

- DataReductionProxyParams::kFallbackAllowed |

- DataReductionProxyParams::kPromoAllowed)

- .WithParamsDefinitions(

- TestDataReductionProxyParams::HAS_EVERYTHING &

- ~TestDataReductionProxyParams::HAS_DEV_ORIGIN &

- ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN)

.WithURLRequestContext(&context)

.WithTestConfigurator()

.SkipSettingsInitialization()

@@ -219,13 +212,6 @@ TEST(DataReductionProxySettingsStandaloneTest, TestOnProxyEnabledPrefChange) {

base::MessageLoopForIO message_loop;