components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc - Issue 1141023002: Record UMA about the response's proxy_server in the DRP bypass logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

Issue 1141023002: Record UMA about the response's proxy_server in the DRP bypass logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased on master again Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

index 96a80d75f6c7d874d147dee3b5fe7ae7c4ffbdd0..a9d620d2f9de138502aae5e7d610d0725c8c368f 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc

@@ -203,8 +203,13 @@ TestDataReductionProxyIOData::~TestDataReductionProxyIOData() {

}

DataReductionProxyTestContext::Builder::Builder()

- : params_flags_(0),

- params_definitions_(0),

+ : params_flags_(DataReductionProxyParams::kAllowed |

+ DataReductionProxyParams::kFallbackAllowed |

+ DataReductionProxyParams::kPromoAllowed),

+ params_definitions_(

+ TestDataReductionProxyParams::HAS_EVERYTHING &

+ ~TestDataReductionProxyParams::HAS_DEV_ORIGIN &

+ ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN),

client_(Client::UNKNOWN),

request_context_(nullptr),

mock_socket_factory_(nullptr),