Make RegExp's constructor non-const.

utils/pub/io.dart

Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index e89bf956f90a71bfa2c60e462eb455a32871107e..c294cc0a4a74ff52f758ad32a54678da4ccebab5 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -21,7 +21,7 @@ String _gitCommandCache;
 /** Gets the current working directory. */
 String get currentWorkingDir => new File('.').fullPathSync();
 
-const Pattern NEWLINE_PATTERN = const RegExp("\r\n?|\n\r?");
+final Pattern NEWLINE_PATTERN = new RegExp("\r\n?|\n\r?");

[Bob Nystrom, 2012/11/12 18:55:05]

Can you remove the type annotation here while you're at it?

[Anders Johnsen, 2012/11/13 06:42:32]

Done.

 
 /**
  * Prints the given string to `stderr` on its own line.
@@ -382,7 +382,7 @@ String getFullPath(entry) {
   if (Platform.operatingSystem == 'windows') {
     // An absolute path on Windows is either UNC (two leading backslashes),
     // or a drive letter followed by a colon and a slash.
-    const ABSOLUTE = const RegExp(r'^(\\\\|[a-zA-Z]:[/\\])');
+    final ABSOLUTE = new RegExp(r'^(\\\\|[a-zA-Z]:[/\\])');

[Bob Nystrom, 2012/11/12 18:55:05]

"final" -> "var"

[Anders Johnsen, 2012/11/13 06:42:32]

Done.

     if (ABSOLUTE.hasMatch(path)) return path;
   } else {
     if (path.startsWith('/')) return path;