Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1140503004: Switch default float-abi for ARM linux from softfp to hard (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch default float-abi for ARM linux from softfp to hard All the ARM linux builders already specify this, and armhf is the now the default for both Ubuntu and Debian. Followup cleanup cl for the bots: https://codereview.chromium.org/1141643004/ BUG=308256 Committed: https://crrev.com/ff8ec298fd273181647ec4d94c032343382dbe57 Cr-Commit-Position: refs/heads/master@{#330316}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/build_artifacts.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/tests/build_artifacts_test.py View 1 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam Clegg
5 years, 7 months ago (2015-05-15 22:38:24 UTC) #2
Lei Zhang
lgtm, but you may need a build/OWNERS?
5 years, 7 months ago (2015-05-15 22:40:59 UTC) #3
Sam Clegg
+dpranke for build/OWNERS
5 years, 7 months ago (2015-05-16 00:26:37 UTC) #5
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-16 21:24:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140503004/50001
5 years, 7 months ago (2015-05-17 22:48:32 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 7 months ago (2015-05-17 23:52:57 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:33:09 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ff8ec298fd273181647ec4d94c032343382dbe57
Cr-Commit-Position: refs/heads/master@{#330316}

Powered by Google App Engine
This is Rietveld 408576698