Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: native_client_sdk/src/build_tools/tests/build_artifacts_test.py

Issue 1140503004: Switch default float-abi for ARM linux from softfp to hard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « native_client_sdk/src/build_tools/build_sdk.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: native_client_sdk/src/build_tools/tests/build_artifacts_test.py
diff --git a/native_client_sdk/src/build_tools/tests/build_artifacts_test.py b/native_client_sdk/src/build_tools/tests/build_artifacts_test.py
index aa71502bf047db40414568bf9be5771c7fdd1f0f..b40339ff7eafc90ae6b8f4dc28618652aede7537 100755
--- a/native_client_sdk/src/build_tools/tests/build_artifacts_test.py
+++ b/native_client_sdk/src/build_tools/tests/build_artifacts_test.py
@@ -189,8 +189,7 @@ class GypNinjaPosixTestCase(BasePosixTestCase):
'GYP_CROSSCOMPILE': '1',
'GYP_GENERATORS': 'ninja',
'GYP_DEFINES': ' '.join(self.gyp_defines_base +
- ['target_arch=arm',
- 'arm_float_abi=hard']),
+ ['target_arch=arm']),
}),
call(['ninja', '-C', 'out_dir/Release', 'target'], cwd='src_dir')
])
@@ -209,7 +208,6 @@ class GypNinjaPosixTestCase(BasePosixTestCase):
'GYP_GENERATORS': 'ninja',
'GYP_DEFINES': ' '.join(self.gyp_defines_base +
['target_arch=arm',
- 'arm_float_abi=hard',
'disable_cross_trusted=1']),
}),
call(['ninja', '-C', 'out_dir/Release', 'target'], cwd='src_dir')
« no previous file with comments | « native_client_sdk/src/build_tools/build_sdk.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698