Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140153006: Remove Navigation Transitions from Blink. (Closed)

Created:
5 years, 7 months ago by dglazkov
Modified:
5 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, dglazkov+blink, dstockwell, eae+blinkwatch, Eric Willigers, gavinp+loader_chromium.org, Nate Chapin, Mike Lawther (Google), rjwright, rwlbuis, shans, sof, Steve Block, Timothy Loh, tyoshino+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove Navigation Transitions from Blink. This is part 2 of https://codereview.chromium.org/1144463003. BUG=370696 R=esprehn Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195658

Patch Set 1 #

Patch Set 2 : Remove more stubs. #

Patch Set 3 : Clean up internals and style engine. #

Patch Set 4 : Removed layout tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -956 lines) Patch
D LayoutTests/fast/dom/HTMLLinkElement/transition-exiting-stylesheet-enable-disable.html View 1 2 3 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/transition-exiting-stylesheet-enable-disable-expected.txt View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/transition-exiting-stylesheet-initially-disabled.html View 1 2 3 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/HTMLLinkElement/transition-exiting-stylesheet-initially-disabled-expected.txt View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/html/navigation-transition.html View 1 2 3 1 chunk +0 lines, -122 lines 0 comments Download
D LayoutTests/fast/html/navigation-transition-expected.txt View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 3 chunks +0 lines, -13 lines 0 comments Download
D Source/core/css/navigationTransitions.css View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 3 chunks +0 lines, -21 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 2 chunks +0 lines, -70 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleEngine.cpp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.cpp View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/editing/HTMLInterchange.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/StyledMarkupAccumulator.cpp View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/editing/StyledMarkupSerializer.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/editing/markup.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 2 3 1 chunk +1 line, -12 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 2 3 chunks +2 lines, -11 lines 0 comments Download
M Source/core/html/LinkRelAttribute.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/LinkRelAttribute.cpp View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 3 3 chunks +2 lines, -29 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 2 4 chunks +3 lines, -19 lines 0 comments Download
M Source/web/WebDocument.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/tests/WebDocumentTest.cpp View 1 2 3 1 chunk +0 lines, -148 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 3 chunks +1 line, -89 lines 0 comments Download
M public/blink_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebDocument.h View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 5 chunks +2 lines, -12 lines 0 comments Download
M public/web/WebLocalFrame.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D public/web/WebTransitionElementData.h View 1 2 1 chunk +0 lines, -60 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dglazkov
PTAL
5 years, 7 months ago (2015-05-20 21:09:15 UTC) #2
esprehn
lgtm
5 years, 7 months ago (2015-05-20 22:41:56 UTC) #3
esprehn
I'm a doctor, not a navigation transition!
5 years, 7 months ago (2015-05-20 22:44:19 UTC) #4
dglazkov
On 2015/05/20 at 22:44:19, esprehn wrote: > I'm a doctor, not a navigation transition! Dr. ...
5 years, 7 months ago (2015-05-20 23:23:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140153006/60001
5 years, 7 months ago (2015-05-21 01:21:53 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 01:27:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195658

Powered by Google App Engine
This is Rietveld 408576698