Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1144463003: Remove Navigation Transitions from Chromium (Closed)

Created:
5 years, 7 months ago by dglazkov
Modified:
5 years, 7 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This was a good experiment, but there's nobody currently driving this iteration, and the code is intrusive, accumulating technical debt around it. BUG=370696 Committed: https://crrev.com/cd24f7e8d5d05cae491599aea8bab20da4e7e6ac Cr-Commit-Position: refs/heads/master@{#330380}

Patch Set 1 #

Patch Set 2 : Fix DidStartProvisionalLoad compile fix. #

Patch Set 3 : Removed ResumeResponseDeferredAtStart, more Android fixes." #

Patch Set 4 : Fixing Android Compile. #

Patch Set 5 : More android fixes." #

Patch Set 6 : I don't have Android build handy. #

Patch Set 7 : Removed TransitionPageHelper. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3060 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 2 3 4 5 6 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationParams.java View 1 2 3 4 5 6 8 chunks +2 lines, -21 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/tab/TransitionPageHelper.java View 1 2 3 4 5 6 1 chunk +0 lines, -951 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/android/transition_page_helper.h View 1 2 3 4 5 6 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/android/transition_page_helper.cc View 1 2 3 4 5 6 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 2 3 4 5 6 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/frame_host/navigator.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/navigator_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigator_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 4 chunks +1 line, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 4 chunks +2 lines, -28 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.h View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 2 4 chunks +1 line, -58 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_helper.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
D content/browser/transition_browsertest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
D content/browser/transition_request_manager.h View 1 chunk +0 lines, -139 lines 0 comments Download
D content/browser/transition_request_manager.cc View 1 chunk +0 lines, -230 lines 0 comments Download
D content/browser/transition_request_manager_unittest.cc View 1 chunk +0 lines, -172 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 1 2 3 4 5 2 chunks +0 lines, -28 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 2 3 4 5 3 chunks +0 lines, -176 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 4 chunks +0 lines, -13 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 4 chunks +0 lines, -34 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/frame_messages.h View 3 chunks +2 lines, -18 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 2 3 4 5 6 chunks +0 lines, -138 lines 0 comments Download
D content/public/android/java/src/org/chromium/content_public/browser/NavigationTransitionDelegate.java View 1 2 3 1 chunk +0 lines, -59 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 2 3 4 2 chunks +0 lines, -57 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/TransitionTest.java View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
M content/renderer/render_frame_impl.h View 6 chunks +3 lines, -12 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 6 chunks +7 lines, -60 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/test/test_render_frame_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
dglazkov
PTAL.
5 years, 7 months ago (2015-05-15 23:17:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-15 23:26:12 UTC) #3
oystein (OOO til 10th of July)
lgtm, thanks for this!
5 years, 7 months ago (2015-05-16 01:02:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144463003/100001
5 years, 7 months ago (2015-05-18 14:57:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64364)
5 years, 7 months ago (2015-05-18 15:05:38 UTC) #8
jam
lgtm
5 years, 7 months ago (2015-05-18 15:42:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144463003/100001
5 years, 7 months ago (2015-05-18 15:46:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64369)
5 years, 7 months ago (2015-05-18 15:54:30 UTC) #13
dglazkov
+jschuh,dcheng -- need your signature for content/common/frame_messages.h
5 years, 7 months ago (2015-05-18 15:57:30 UTC) #15
jschuh
ipc security lgtm. (notes: message/code removal)
5 years, 7 months ago (2015-05-18 16:27:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144463003/100001
5 years, 7 months ago (2015-05-18 16:37:21 UTC) #18
commit-bot: I haz the power
Committed patchset #7 (id:100001)
5 years, 7 months ago (2015-05-18 20:00:10 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:40:48 UTC) #20
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/cd24f7e8d5d05cae491599aea8bab20da4e7e6ac
Cr-Commit-Position: refs/heads/master@{#330380}

Powered by Google App Engine
This is Rietveld 408576698