Remove Navigation Transitions from Blink.

Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 4840 matching lines @@
 TEST_F(WebFrameTest, MoveCaretSelectionTowardsWindowPointWithNoSelection)
 {
     FrameTestHelpers::WebViewHelper webViewHelper;
     webViewHelper.initializeAndLoad("about:blank", true);
     WebFrame* frame = webViewHelper.webView()->mainFrame();
 
     // This test passes if this doesn't crash.
     frame->moveCaretSelection(WebPoint(0, 0));
 }
 
-TEST_F(WebFrameTest, NavigateToSandboxedMarkup)
-{
-    FrameTestHelpers::TestWebFrameClient webFrameClient;
-    FrameTestHelpers::WebViewHelper webViewHelper;
-    WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad("about:blank", true, &webFrameClient);
-    WebLocalFrameImpl* frame = toWebLocalFrameImpl(webViewHelper.webView()->mainFrame());
-
-    frame->document().setIsTransitionDocument(true);
-
-    std::string markup("<div id='foo'></div><script>document.getElementById('foo').setAttribute('dir', 'rtl')</script>");
-    frame->navigateToSandboxedMarkup(WebData(markup.data(), markup.length()));
-
-    webFrameClient.waitForLoadToComplete();
-
-    WebDocument document = webViewImpl->mainFrame()->document();
-    WebElement transitionElement = document.getElementById("foo");
-    // Check that the markup got navigated to successfully.
-    EXPECT_FALSE(transitionElement.isNull());
-
-    // Check that the inline script was not executed.
-    EXPECT_FALSE(transitionElement.hasAttribute("dir"));
-}
-
 class SpellCheckClient : public WebSpellCheckClient {
 public:
     explicit SpellCheckClient(uint32_t hash = 0) : m_numberOfTimesChecked(0), m_hash(hash) { }
     virtual ~SpellCheckClient() { }
     virtual void requestCheckingOfText(const WebString&, const WebVector<uint32_t>&, const WebVector<unsigned>&, WebTextCheckingCompletion* completion) override
     {
         ++m_numberOfTimesChecked;
         Vector<WebTextCheckingResult> results;
         const int misspellingStartOffset = 1;
         const int misspellingLength = 8;
@@ skipping 998 matching lines @@
 }
 
 class TestHistoryWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
 public:
     TestHistoryWebFrameClient()
     {
         m_replacesCurrentHistoryItem = false;
         m_frame = nullptr;
     }
 
-    void didStartProvisionalLoad(WebLocalFrame* frame, bool isTransitionNavigation, double)
+    void didStartProvisionalLoad(WebLocalFrame* frame, double)
     {
         WebDataSource* ds = frame->provisionalDataSource();
         m_replacesCurrentHistoryItem = ds->replacesCurrentHistoryItem();
         m_frame = frame;
     }
 
     bool replacesCurrentHistoryItem() { return m_replacesCurrentHistoryItem; }
     WebFrame* frame() { return m_frame; }
 
 private:
@@ skipping 1349 matching lines @@
     EXPECT_TRUE(client.failed());
 
     client.reset();
     // Try to load the request with cross origin access. Should succeed.
     options.crossOriginRequestPolicy = AllowCrossOriginRequests;
     DocumentThreadableLoader::loadResourceSynchronously(
         *frame->document(), ResourceRequest(resourceUrl), client, options, resourceLoaderOptions);
     EXPECT_FALSE(client.failed());
 }
 
-class NavigationTransitionCallbackWebFrameClient : public FrameTestHelpers::TestWebFrameClient {
-public:
-    NavigationTransitionCallbackWebFrameClient()
-        : m_navigationalDataReceivedCount(0)
-        , m_provisionalLoadCount(0)
-        , m_wasLastProvisionalLoadATransition(false) { }
-
-    virtual void addNavigationTransitionData(const WebTransitionElementData& data) override
-    {
-        m_navigationalDataReceivedCount++;
-    }
-
-    virtual void didStartProvisionalLoad(WebLocalFrame* localFrame, bool isTransitionNavigation, double) override
-    {
-        m_provisionalLoadCount++;
-        m_wasLastProvisionalLoadATransition = isTransitionNavigation;
-    }
-
-    unsigned navigationalDataReceivedCount() const { return m_navigationalDataReceivedCount; }
-    unsigned provisionalLoadCount() const { return m_provisionalLoadCount; }
-    bool wasLastProvisionalLoadATransition() const { return m_wasLastProvisionalLoadATransition; }
-
-private:
-    unsigned m_navigationalDataReceivedCount;
-    unsigned m_provisionalLoadCount;
-    bool m_wasLastProvisionalLoadATransition;
-};
-
-TEST_F(WebFrameTest, NavigationTransitionCallbacks)
-{
-    RuntimeEnabledFeatures::setNavigationTransitionsEnabled(true);
-    FrameTestHelpers::WebViewHelper viewHelper;
-    NavigationTransitionCallbackWebFrameClient frameClient;
-    WebLocalFrame* localFrame = viewHelper.initialize(true, &frameClient)->mainFrame()->toWebLocalFrame();
-
-    const char* transitionHTMLString =
-        "<!DOCTYPE html>"
-        "<meta name='transition-elements' content='#foo;*'>"
-        "<div id='foo'>";
-
-    // Initial document load should not be a transition.
-    FrameTestHelpers::loadHTMLString(localFrame, transitionHTMLString, toKURL("http://internal.test"));
-    EXPECT_EQ(1u, frameClient.provisionalLoadCount());
-    EXPECT_FALSE(frameClient.wasLastProvisionalLoadATransition());
-    EXPECT_EQ(0u, frameClient.navigationalDataReceivedCount());
-
-    // Going from internal.test containing transition elements to about:blank, should be a transition.
-    FrameTestHelpers::loadHTMLString(localFrame, transitionHTMLString, toKURL("about:blank"));
-    EXPECT_EQ(2u, frameClient.provisionalLoadCount());
-    EXPECT_TRUE(frameClient.wasLastProvisionalLoadATransition());
-    EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount());
-
-    // Navigating to the URL of the current page shouldn't be a transition.
-    FrameTestHelpers::loadHTMLString(localFrame, transitionHTMLString, toKURL("about:blank"));
-    EXPECT_EQ(3u, frameClient.provisionalLoadCount());
-    EXPECT_FALSE(frameClient.wasLastProvisionalLoadATransition());
-    EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount());
-
-    // Neither should a page reload.
-    localFrame->reload();
-    EXPECT_EQ(4u, frameClient.provisionalLoadCount());
-    EXPECT_FALSE(frameClient.wasLastProvisionalLoadATransition());
-    EXPECT_EQ(1u, frameClient.navigationalDataReceivedCount());
-}
-
 TEST_F(WebFrameTest, DetachRemoteFrame)
 {
     FrameTestHelpers::TestWebViewClient viewClient;
     FrameTestHelpers::TestWebRemoteFrameClient remoteClient;
     WebView* view = WebView::create(&viewClient);
     view->setMainFrame(remoteClient.frame());
     FrameTestHelpers::TestWebRemoteFrameClient childFrameClient;
     WebRemoteFrame* childFrame = view->mainFrame()->toWebRemoteFrame()->createRemoteChild("", WebSandboxFlags::None, &childFrameClient);
     childFrame->detach();
     view->close();
@@ skipping 76 matching lines @@
 
     EXPECT_EQ(parent, firstFrame->parent());
     EXPECT_EQ(parent, secondFrame->parent());
     EXPECT_EQ(parent, thirdFrame->parent());
     EXPECT_EQ(parent, fourthFrame->parent());
 
     view->close();
 }
 
 } // namespace blink