chrome/browser/extensions/api/web_navigation/frame_navigation_state.h - Issue 1140023002: Code Refactor and making function static in frame_navigation_state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

Issue 1140023002: Code Refactor and making function static in frame_navigation_state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc » ('j') | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

diff --git a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

index 2e4a30096c985bd0603ea12065c95a1a45c3dc95..e923f1858796be0fd916a2b6a07142ca489bd8f9 100644

--- a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

+++ b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

@@ -35,9 +35,8 @@ class FrameNavigationState {

// True if navigation events for the given frame can be sent.

bool CanSendEvents(content::RenderFrameHost* frame_host) const;

- // TODO(dcheng): This should be static.

// True if in general webNavigation events may be sent for the given URL.

- bool IsValidUrl(const GURL& url) const;

+ static bool IsValidUrl(const GURL& url);

nasko 2015/05/14 17:00:41 static methods should be declared at the beginning

// Starts to track a navigation in |frame_host| to |url|.

void StartTrackingNavigation(content::RenderFrameHost* frame_host,