Code Refactor and making function static in frame_navigation_state.

chrome/browser/extensions/api/web_navigation/frame_navigation_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_FRAME_NAVIGATION_STATE_H_
 #define CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_FRAME_NAVIGATION_STATE_H_
 
 #include <map>
 #include <set>
 
@@ skipping 17 matching lines @@
   FrameNavigationState();
   ~FrameNavigationState();
 
   // Use these to iterate over all frame hosts known by this object.
   const_iterator begin() const { return frame_hosts_.begin(); }
   const_iterator end() const { return frame_hosts_.end(); }
 
   // True if navigation events for the given frame can be sent.
   bool CanSendEvents(content::RenderFrameHost* frame_host) const;
 
-  // TODO(dcheng): This should be static.
   // True if in general webNavigation events may be sent for the given URL.
-  bool IsValidUrl(const GURL& url) const;
+  static bool IsValidUrl(const GURL& url);

[nasko, 2015/05/14 17:00:41]

static methods should be declared at the beginning of the section. Once you move
it up, please ensure the same ordering is applied to the .cc file.

 
   // Starts to track a navigation in |frame_host| to |url|.
   void StartTrackingNavigation(content::RenderFrameHost* frame_host,
                                const GURL& url,
                                bool is_error_page,
                                bool is_iframe_srcdoc);
 
   // Adds the |frame_host| to the set of RenderFrameHosts associated with the
   // WebContents this object is tracking. This method and FrameHostDeleted
   // are used to track the set of current RenderFrameHosts, which is used to
@@ skipping 76 matching lines @@
 
   // If true, also allow events from chrome-extension:// URLs.
   static bool allow_extension_scheme_;
 
   DISALLOW_COPY_AND_ASSIGN(FrameNavigationState);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_FRAME_NAVIGATION_STATE_H_